Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: PRESUBMIT.py

Issue 2316373003: Presubmit: Warn about using XSelectInput (Closed)
Patch Set: Update dependent patch set Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index e2e042336926e54a01f47dd33769c9a534c7c92c..0076836a086d7d5f7530b3f8caff282c84ad9f98 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -164,6 +164,21 @@ _BANNED_CPP_FUNCTIONS = (
(),
),
(
+ r'XSelectInput|CWEventMask|XCB_CW_EVENT_MASK',
+ (
+ 'Chrome clients wishing to select events on X windows should use',
+ 'ui::XScopedEventSelector. It is safe to ignore this warning only if',
+ 'you are selecting events from the GPU process, or if you are using',
+ 'an XDisplay other than gfx::GetXDisplay().',
+ ),
+ True,
+ (
+ r"^ui[\\\/]gl[\\\/].*\.cc$",
+ r"^media[\\\/]gpu[\\\/].*\.cc$",
+ r"^gpu[\\\/].*\.cc$",
+ ),
+ ),
+ (
'ScopedAllowIO',
(
'New code should not use ScopedAllowIO. Post a task to the blocking',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698