Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issue 2316323002: Remove force parameter from bot_update.ensure_checkout. (Closed)

Created:
4 years, 3 months ago by iannucci
Modified:
4 years, 3 months ago
Reviewers:
agable, estaab, martiniss, hinoka
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove force parameter from bot_update.ensure_checkout. This is the simplest change I can make here. The bot_update.py script already ignores the value of force (and sets it to True in all cases). This is an expectations-only change. I'll refactor the content of the bot_update.py script to account for this removed option in a followup CL as well. R=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org BUG=643885 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/990ab1b42c1f347686a509aade4303289f779902

Patch Set 1 #

Patch Set 2 : Remove assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -108 lines) Patch
M recipe_modules/bot_update/api.py View 1 3 chunks +2 lines, -5 lines 0 comments Download
M recipe_modules/bot_update/example.py View 3 chunks +0 lines, -8 lines 0 comments Download
D recipe_modules/bot_update/example.expected/forced.json View 1 chunk +0 lines, -57 lines 0 comments Download
M recipe_modules/bot_update/test_api.py View 1 chunk +34 lines, -38 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
iannucci
4 years, 3 months ago (2016-09-07 20:17:54 UTC) #1
hinoka
lgtm
4 years, 3 months ago (2016-09-07 20:22:22 UTC) #2
agable
lgtm
4 years, 3 months ago (2016-09-07 22:08:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316323002/20001
4 years, 3 months ago (2016-09-08 17:52:54 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 17:56:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/990ab1b42c1f34...

Powered by Google App Engine
This is Rietveld 408576698