Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: recipe_modules/bot_update/test_api.py

Issue 2316323002: Remove force parameter from bot_update.ensure_checkout. (Closed)
Patch Set: Remove assert Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « recipe_modules/bot_update/example.expected/forced.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_modules/bot_update/test_api.py
diff --git a/recipe_modules/bot_update/test_api.py b/recipe_modules/bot_update/test_api.py
index afe524a6318474c96ac077f9d5c79ae72aebc7ae..eeeb49ba660d2ece56d37158dce736e2470f3679 100644
--- a/recipe_modules/bot_update/test_api.py
+++ b/recipe_modules/bot_update/test_api.py
@@ -11,57 +11,53 @@ from recipe_engine import recipe_test_api
class BotUpdateTestApi(recipe_test_api.RecipeTestApi):
def output_json(self, master, builder, slave, root, first_sln,
- revision_mapping, force=False, fail_patch=False,
+ revision_mapping, fail_patch=False,
output_manifest=False, fixed_revisions=None):
"""Deterministically synthesize json.output test data for gclient's
--output-json option.
"""
- active = True
-
output = {
- 'did_run': active,
+ 'did_run': True,
'patch_failure': False
}
- # Add in extra json output if active.
- if active:
- properties = {
- property_name: self.gen_revision(project_name)
- for project_name, property_name in revision_mapping.iteritems()
- }
- properties.update({
- '%s_cp' % property_name: ('refs/heads/master@{#%s}' %
- self.gen_commit_position(project_name))
- for project_name, property_name in revision_mapping.iteritems()
- })
+ properties = {
+ property_name: self.gen_revision(project_name)
+ for project_name, property_name in revision_mapping.iteritems()
+ }
+ properties.update({
+ '%s_cp' % property_name: ('refs/heads/master@{#%s}' %
+ self.gen_commit_position(project_name))
+ for project_name, property_name in revision_mapping.iteritems()
+ })
- output.update({
- 'patch_root': root or first_sln,
- 'root': first_sln,
- 'properties': properties,
- 'step_text': 'Some step text'
- })
+ output.update({
+ 'patch_root': root or first_sln,
+ 'root': first_sln,
+ 'properties': properties,
+ 'step_text': 'Some step text'
+ })
- if output_manifest:
- output.update({
- 'manifest': {
- project_name: {
- 'repository': 'https://fake.org/%s.git' % project_name,
- 'revision': self.gen_revision(project_name),
- }
- for project_name in revision_mapping
+ if output_manifest:
+ output.update({
+ 'manifest': {
+ project_name: {
+ 'repository': 'https://fake.org/%s.git' % project_name,
+ 'revision': self.gen_revision(project_name),
}
- })
+ for project_name in revision_mapping
+ }
+ })
- if fixed_revisions:
- output['fixed_revisions'] = fixed_revisions
+ if fixed_revisions:
+ output['fixed_revisions'] = fixed_revisions
- if fail_patch:
- output['log_lines'] = [('patch error', 'Patch failed to apply'),]
- output['patch_failure'] = True
- output['patch_apply_return_code'] = 1
- if fail_patch == 'download':
- output['patch_apply_return_code'] = 3
+ if fail_patch:
+ output['log_lines'] = [('patch error', 'Patch failed to apply'),]
+ output['patch_failure'] = True
+ output['patch_apply_return_code'] = 1
+ if fail_patch == 'download':
+ output['patch_apply_return_code'] = 3
return self.m.json.output(output)
@staticmethod
« no previous file with comments | « recipe_modules/bot_update/example.expected/forced.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698