Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: recipe_modules/bot_update/example.py

Issue 2316323002: Remove force parameter from bot_update.ensure_checkout. (Closed)
Patch Set: Remove assert Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « recipe_modules/bot_update/api.py ('k') | recipe_modules/bot_update/example.expected/forced.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_modules/bot_update/example.py
diff --git a/recipe_modules/bot_update/example.py b/recipe_modules/bot_update/example.py
index a369997c7bc4d7af26df13cebaa90da8aec2ff43..8f0182d166556f8fb418896d63475284cac2f2aa 100644
--- a/recipe_modules/bot_update/example.py
+++ b/recipe_modules/bot_update/example.py
@@ -25,7 +25,6 @@ def RunSteps(api):
'HEAD')
patch = api.properties.get('patch', True)
clobber = True if api.properties.get('clobber') else False
- force = True if api.properties.get('force') else False
no_shallow = True if api.properties.get('no_shallow') else False
output_manifest = api.properties.get('output_manifest', False)
with_branch_heads = api.properties.get('with_branch_heads', False)
@@ -44,7 +43,6 @@ def RunSteps(api):
gerrit_no_rebase_patch_ref=gerrit_no_rebase_patch_ref)
else:
api.bot_update.ensure_checkout(
- force=force,
no_shallow=no_shallow,
patch=patch,
with_branch_heads=with_branch_heads,
@@ -124,12 +122,6 @@ def GenTests(api):
rietveld='https://rietveld.example.com/',
fail_patch='download'
) + api.step_data('bot_update', retcode=87)
- yield api.test('forced') + api.properties(
- mastername='experimental',
- buildername='Experimental Builder',
- slavename='somehost',
- force=1
- )
yield api.test('no_shallow') + api.properties(
mastername='experimental',
buildername='Experimental Builder',
« no previous file with comments | « recipe_modules/bot_update/api.py ('k') | recipe_modules/bot_update/example.expected/forced.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698