Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2316303006:
Make default spellchecking behavior in html elements configurable via WebSettings. (Closed)
|
Created:
4 years, 3 months ago by timvolodine Modified:
4 years, 2 months ago CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, do_not_use, Tobias Sargeant, groby-ooo-7-16, Peter Beverloo Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake default spellchecking behavior in html elements configurable via WebSettings.
This patch introduces the setSpellCheckEnabledByDefault method in
WebSettings to allow control over whether spellchecking should be
enabled by default in spellcheck-capable html elements (e.g. text
<input> elements and elements with the contenteditable="true"
attribute).
Currently the default behavior is that spellcheck is enabled. This
patch does not actually change any defaults or functionality, instead
this would happen at a later stage in a separate patch. For example on
Android where we may want to change the default for performance
reasons, or in Android WebView due to consistency considerations.
BUG=583616, 629609
Committed: https://crrev.com/b0a6d1d8932f6d5a1bbdfb4a650e139d6557163c
Cr-Commit-Position: refs/heads/master@{#421808}
Patch Set 1 #
Total comments: 3
Patch Set 2 : make it configurable via settings #
Total comments: 2
Patch Set 3 : address Rick's comments add tests #Patch Set 4 : correct version of spellcheck-attribute-default.html #Patch Set 5 : rebase #Patch Set 6 : rename test files to "..settings-default.." #Patch Set 7 : enable the test and update description #Patch Set 8 : fix expectations #
Total comments: 2
Patch Set 9 : rebase add doctype #Patch Set 10 : remove setting of spellcheck default in render_view_impl #Messages
Total messages: 62 (43 generated)
The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [Android] Disable spellchecking in html elements by default on Android. This patch makes spellchecking on spellcheck-capable html elements (e.g. text <input> elements and elements with the contenteditable="true" attribute) disabled by default on Android. On other platforms it remains enabled by default as before. On Android spellchecking invokes platform-side service and involves some IPC overhead and extra cpu cycles. To increase performance and save battery on mobile devices we make spellchecking "opt-in". It can be explicitly enabled by adding the spellcheck="true" attribute. BUG=583616, 629609 ========== to ========== [Android] Disable spellchecking in html elements by default on Android. This patch makes spellchecking on spellcheck-capable html elements (e.g. text <input> elements and elements with the contenteditable="true" attribute) disabled by default on Android. On other platforms it remains enabled by default as before. On Android spellchecking invokes platform-side service and involves some IPC overhead and extra cpu cycles. To increase performance and save battery on mobile devices we make spellchecking "opt-in". It can be explicitly enabled by adding the spellcheck="true" attribute. NOTE: this patch is to be landed once the currently running finch experiment is complete. BUG=583616, 629609 ==========
Description was changed from ========== [Android] Disable spellchecking in html elements by default on Android. This patch makes spellchecking on spellcheck-capable html elements (e.g. text <input> elements and elements with the contenteditable="true" attribute) disabled by default on Android. On other platforms it remains enabled by default as before. On Android spellchecking invokes platform-side service and involves some IPC overhead and extra cpu cycles. To increase performance and save battery on mobile devices we make spellchecking "opt-in". It can be explicitly enabled by adding the spellcheck="true" attribute. NOTE: this patch is to be landed once the currently running finch experiment is complete. BUG=583616, 629609 ========== to ========== [Android] Disable spellchecking in html elements by default on Android. DO NOT LAND YET This patch makes spellchecking on spellcheck-capable html elements (e.g. text <input> elements and elements with the contenteditable="true" attribute) disabled by default on Android. On other platforms it remains enabled by default as before. On Android spellchecking invokes platform-side service and involves some IPC overhead and extra cpu cycles. To increase performance and save battery on mobile devices we make spellchecking "opt-in". It can be explicitly enabled by adding the spellcheck="true" attribute. NOTE: this patch is to be landed once the currently running finch experiment is complete. BUG=583616, 629609 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
timvolodine@chromium.org changed reviewers: + rbyers@chromium.org
Description was changed from ========== [Android] Disable spellchecking in html elements by default on Android. DO NOT LAND YET This patch makes spellchecking on spellcheck-capable html elements (e.g. text <input> elements and elements with the contenteditable="true" attribute) disabled by default on Android. On other platforms it remains enabled by default as before. On Android spellchecking invokes platform-side service and involves some IPC overhead and extra cpu cycles. To increase performance and save battery on mobile devices we make spellchecking "opt-in". It can be explicitly enabled by adding the spellcheck="true" attribute. NOTE: this patch is to be landed once the currently running finch experiment is complete. BUG=583616, 629609 ========== to ========== [Android] Disable spellchecking in html elements by default on Android. DO NOT LAND YET This patch makes spellchecking on spellcheck-capable html elements (e.g. text <input> elements and elements with the contenteditable="true" attribute) disabled by default on Android. On other platforms it remains enabled by default as before. On Android, spellchecking invokes platform-side service and involves some IPC overhead and extra cpu cycles. To increase performance and save battery on mobile devices we make spellchecking "opt-in". It can be explicitly enabled by adding the spellcheck="true" attribute. NOTE: this patch is to be landed once the currently running finch experiment is complete. BUG=583616, 629609 ==========
On 2016/09/12 14:38:19, timvolodine wrote: note: this does not break existing behavior because we have not shipped spellcheck feature on Android yet.
Description was changed from ========== [Android] Disable spellchecking in html elements by default on Android. DO NOT LAND YET This patch makes spellchecking on spellcheck-capable html elements (e.g. text <input> elements and elements with the contenteditable="true" attribute) disabled by default on Android. On other platforms it remains enabled by default as before. On Android, spellchecking invokes platform-side service and involves some IPC overhead and extra cpu cycles. To increase performance and save battery on mobile devices we make spellchecking "opt-in". It can be explicitly enabled by adding the spellcheck="true" attribute. NOTE: this patch is to be landed once the currently running finch experiment is complete. BUG=583616, 629609 ========== to ========== [Android] Disable spellchecking in html elements by default on Android. DO NOT LAND YET This patch makes spellchecking in spellcheck-capable html elements (e.g. text <input> elements and elements with the contenteditable="true" attribute) disabled by default on Android. On other platforms it remains enabled by default as before. On Android, spellchecking invokes platform-side service and involves some IPC overhead and extra cpu cycles. To increase performance and save battery on mobile devices we make spellchecking "opt-in". It can be explicitly enabled by adding the spellcheck="true" attribute. NOTE: this patch is to be landed once the currently running finch experiment is complete. BUG=583616, 629609 ==========
Description was changed from ========== [Android] Disable spellchecking in html elements by default on Android. DO NOT LAND YET This patch makes spellchecking in spellcheck-capable html elements (e.g. text <input> elements and elements with the contenteditable="true" attribute) disabled by default on Android. On other platforms it remains enabled by default as before. On Android, spellchecking invokes platform-side service and involves some IPC overhead and extra cpu cycles. To increase performance and save battery on mobile devices we make spellchecking "opt-in". It can be explicitly enabled by adding the spellcheck="true" attribute. NOTE: this patch is to be landed once the currently running finch experiment is complete. BUG=583616, 629609 ========== to ========== [Android] Disable spellchecking in html elements by default on Android. DO NOT LAND YET This patch makes spellchecking in spellcheck-capable html elements (e.g. text <input> elements and elements with the contenteditable="true" attribute) disabled by default on Android. On other platforms it remains enabled by default as before. On Android, spellchecking invokes platform-side service and involves some IPC overhead and extra cpu cycles. To increase performance and save battery on mobile devices we make spellchecking "opt-in". It can be explicitly enabled by adding the spellcheck="true" attribute. NOTE: does not break existing behavior because spellcheck has not shipped on Android as of yet. NOTE: this patch is to be landed once the currently running finch experiment is complete. BUG=583616, 629609 ==========
Description was changed from ========== [Android] Disable spellchecking in html elements by default on Android. DO NOT LAND YET This patch makes spellchecking in spellcheck-capable html elements (e.g. text <input> elements and elements with the contenteditable="true" attribute) disabled by default on Android. On other platforms it remains enabled by default as before. On Android, spellchecking invokes platform-side service and involves some IPC overhead and extra cpu cycles. To increase performance and save battery on mobile devices we make spellchecking "opt-in". It can be explicitly enabled by adding the spellcheck="true" attribute. NOTE: does not break existing behavior because spellcheck has not shipped on Android as of yet. NOTE: this patch is to be landed once the currently running finch experiment is complete. BUG=583616, 629609 ========== to ========== [Android] Disable spellchecking in html elements by default on Android. DO NOT LAND YET This patch makes spellchecking in spellcheck-capable html elements (e.g. text <input> elements and elements with the contenteditable="true" attribute) disabled by default on Android. On other platforms it remains enabled by default as before. On Android, spellchecking invokes platform-side service and involves some IPC overhead and extra cpu cycles. To increase performance and save battery on mobile devices we make spellchecking "opt-in". It can be explicitly enabled by adding the spellcheck="true" attribute. NOTE: does not break existing behavior because spellcheck has not shipped on Android as of yet. NOTE: this patch is to be landed once the currently running finch experiment is complete. BUG=583616, 629609 ==========
+cc: groby@
https://codereview.chromium.org/2316303006/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/dom/Element.cpp (right): https://codereview.chromium.org/2316303006/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/dom/Element.cpp:3212: return false; This should probably be a decision made by the embedder, i.e. routed through WebSettings?
Looks like the spec expects the default behavior to be UA defined: https://html.spec.whatwg.org/multipage/interaction.html#spelling-and-grammar-... so this design seems reasonable to me. At some point in the launch of spellcheck support for Android pleas work with jmedley@ to get the default value table on MDN updated to reflect this: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/spellcheck https://codereview.chromium.org/2316303006/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/dom/Element.cpp (right): https://codereview.chromium.org/2316303006/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/dom/Element.cpp:3212: return false; On 2016/09/12 14:59:02, Peter Beverloo wrote: > This should probably be a decision made by the embedder, i.e. routed through > WebSettings? Yes, we avoid adding #ifdefs like this in Blink. Eg. it lets us write tests for both modes that run on all platforms rather than relying on running the tests on Android (which we still don't do for many tests).
The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
timvolodine@chromium.org changed reviewers: + peter@chromium.org
https://codereview.chromium.org/2316303006/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/dom/Element.cpp (right): https://codereview.chromium.org/2316303006/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/dom/Element.cpp:3212: return false; On 2016/09/14 15:21:00, Rick Byers wrote: > On 2016/09/12 14:59:02, Peter Beverloo wrote: > > This should probably be a decision made by the embedder, i.e. routed through > > WebSettings? > > Yes, we avoid adding #ifdefs like this in Blink. Eg. it lets us write tests for > both modes that run on all platforms rather than relying on running the tests on > Android (which we still don't do for many tests). ok, sounds right, thanks for the suggestion Peter! I've now implemented it via settings.
On 2016/09/14 15:21:00, Rick Byers wrote: > Looks like the spec expects the default behavior to be UA defined: > https://html.spec.whatwg.org/multipage/interaction.html#spelling-and-grammar-... > so this design seems reasonable to me. > > At some point in the launch of spellcheck support for Android pleas work with > jmedley@ to get the default value table on MDN updated to reflect this: > https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/spellcheck > Thanks for the pointers Rick, yes we should have sufficient freedom wrt choosing the defaults.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Yep this looks great, thanks. Now, what about a test? Is there already a basic spell-checking test which we can extend to test the difference in behavior when the setting is off by default (verify that it can still be turned on explicitly etc.)? https://codereview.chromium.org/2316303006/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/dom/Element.cpp (right): https://codereview.chromium.org/2316303006/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/dom/Element.cpp:3220: return document().page()->settings().spellCheckEnabledByDefault(); I believe there are cases where page() could be null (but maybe they're just testing cases). To be safe add a null check / fallback.
The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks Rick for the comments, added a layout test for testing the default spellcheck behavior using settings. PTAL. https://codereview.chromium.org/2316303006/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/dom/Element.cpp (right): https://codereview.chromium.org/2316303006/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/dom/Element.cpp:3220: return document().page()->settings().spellCheckEnabledByDefault(); On 2016/09/15 20:28:09, Rick Byers (slow until 9-26) wrote: > I believe there are cases where page() could be null (but maybe they're just > testing cases). To be safe add a null check / fallback. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM with nit https://codereview.chromium.org/2316303006/diff/140001/third_party/WebKit/Lay... File third_party/WebKit/LayoutTests/editing/spelling/spellcheck-attribute-settings-default.html (right): https://codereview.chromium.org/2316303006/diff/140001/third_party/WebKit/Lay... third_party/WebKit/LayoutTests/editing/spelling/spellcheck-attribute-settings-default.html:1: <html> nit: html, head and body tags are normally omitted from layout tests: https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-...
The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [Android] Disable spellchecking in html elements by default on Android. DO NOT LAND YET This patch makes spellchecking in spellcheck-capable html elements (e.g. text <input> elements and elements with the contenteditable="true" attribute) disabled by default on Android. On other platforms it remains enabled by default as before. On Android, spellchecking invokes platform-side service and involves some IPC overhead and extra cpu cycles. To increase performance and save battery on mobile devices we make spellchecking "opt-in". It can be explicitly enabled by adding the spellcheck="true" attribute. NOTE: does not break existing behavior because spellcheck has not shipped on Android as of yet. NOTE: this patch is to be landed once the currently running finch experiment is complete. BUG=583616, 629609 ========== to ========== Make default spellchecking behavior in html elements configurable via WebSettings. This patch introduces the setSpellCheckEnabledByDefault method in WebSettings to allow control over whether spellchecking should be enabled by default in spellcheck-capable html elements (e.g. text <input> elements and elements with the contenteditable="true attribute). Currently the default behavior is that spellcheck is enabled. This patch does not actually change any defaults or functionality, instead this would happen at a later stage in a separate patch. For example on Android where we may want to change the default for performance reasons, or in Android WebView due to consistency considerations. BUG=583616, 629609 ==========
Description was changed from ========== Make default spellchecking behavior in html elements configurable via WebSettings. This patch introduces the setSpellCheckEnabledByDefault method in WebSettings to allow control over whether spellchecking should be enabled by default in spellcheck-capable html elements (e.g. text <input> elements and elements with the contenteditable="true attribute). Currently the default behavior is that spellcheck is enabled. This patch does not actually change any defaults or functionality, instead this would happen at a later stage in a separate patch. For example on Android where we may want to change the default for performance reasons, or in Android WebView due to consistency considerations. BUG=583616, 629609 ========== to ========== Make default spellchecking behavior in html elements configurable via WebSettings. This patch introduces the setSpellCheckEnabledByDefault method in WebSettings to allow control over whether spellchecking should be enabled by default in spellcheck-capable html elements (e.g. text <input> elements and elements with the contenteditable="true" attribute). Currently the default behavior is that spellcheck is enabled. This patch does not actually change any defaults or functionality, instead this would happen at a later stage in a separate patch. For example on Android where we may want to change the default for performance reasons, or in Android WebView due to consistency considerations. BUG=583616, 629609 ==========
https://codereview.chromium.org/2316303006/diff/140001/third_party/WebKit/Lay... File third_party/WebKit/LayoutTests/editing/spelling/spellcheck-attribute-settings-default.html (right): https://codereview.chromium.org/2316303006/diff/140001/third_party/WebKit/Lay... third_party/WebKit/LayoutTests/editing/spelling/spellcheck-attribute-settings-default.html:1: <html> On 2016/09/26 18:44:34, Rick Byers wrote: > nit: html, head and body tags are normally omitted from layout tests: > https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-... yes hmm, however it appears all spellcheck related tests (and actually all tests in this directory) use this structure with tags, so in this instance I am inclined to keep it the same for the sake of consistency.
Actually, planning to land this patch without any default changes for now. We can decide on this separately at a later stage. Changed the title and description accordingly.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/09/27 17:51:56, timvolodine wrote: > https://codereview.chromium.org/2316303006/diff/140001/third_party/WebKit/Lay... > File > third_party/WebKit/LayoutTests/editing/spelling/spellcheck-attribute-settings-default.html > (right): > > https://codereview.chromium.org/2316303006/diff/140001/third_party/WebKit/Lay... > third_party/WebKit/LayoutTests/editing/spelling/spellcheck-attribute-settings-default.html:1: > <html> > On 2016/09/26 18:44:34, Rick Byers wrote: > > nit: html, head and body tags are normally omitted from layout tests: > > > https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-... > > yes hmm, however it appears all spellcheck related tests (and actually all tests > in this directory) use this structure with tags, so in this instance I am > inclined to keep it the same for the sake of consistency. Sure, fine with me.
On 2016/09/27 17:51:56, timvolodine wrote: > https://codereview.chromium.org/2316303006/diff/140001/third_party/WebKit/Lay... > File > third_party/WebKit/LayoutTests/editing/spelling/spellcheck-attribute-settings-default.html > (right): > > https://codereview.chromium.org/2316303006/diff/140001/third_party/WebKit/Lay... > third_party/WebKit/LayoutTests/editing/spelling/spellcheck-attribute-settings-default.html:1: > <html> > On 2016/09/26 18:44:34, Rick Byers wrote: > > nit: html, head and body tags are normally omitted from layout tests: > > > https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-... > > yes hmm, however it appears all spellcheck related tests (and actually all tests > in this directory) use this structure with tags, so in this instance I am > inclined to keep it the same for the sake of consistency. Sure, fine with me.
On 2016/09/27 17:53:44, timvolodine wrote: > Actually, planning to land this patch without any default changes for now. We > can decide on this separately at a later stage. Changed the title and > description accordingly. Sounds good, still LGTM
On 2016/09/28 22:16:18, Rick Byers wrote: > On 2016/09/27 17:53:44, timvolodine wrote: > > Actually, planning to land this patch without any default changes for now. We > > can decide on this separately at a later stage. Changed the title and > > description accordingly. > > Sounds good, still LGTM ok thanks for the review!
The CQ bit was checked by timvolodine@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Make default spellchecking behavior in html elements configurable via WebSettings. This patch introduces the setSpellCheckEnabledByDefault method in WebSettings to allow control over whether spellchecking should be enabled by default in spellcheck-capable html elements (e.g. text <input> elements and elements with the contenteditable="true" attribute). Currently the default behavior is that spellcheck is enabled. This patch does not actually change any defaults or functionality, instead this would happen at a later stage in a separate patch. For example on Android where we may want to change the default for performance reasons, or in Android WebView due to consistency considerations. BUG=583616, 629609 ========== to ========== Make default spellchecking behavior in html elements configurable via WebSettings. This patch introduces the setSpellCheckEnabledByDefault method in WebSettings to allow control over whether spellchecking should be enabled by default in spellcheck-capable html elements (e.g. text <input> elements and elements with the contenteditable="true" attribute). Currently the default behavior is that spellcheck is enabled. This patch does not actually change any defaults or functionality, instead this would happen at a later stage in a separate patch. For example on Android where we may want to change the default for performance reasons, or in Android WebView due to consistency considerations. BUG=583616, 629609 ==========
Message was sent while issue was closed.
Committed patchset #10 (id:180001)
Message was sent while issue was closed.
Description was changed from ========== Make default spellchecking behavior in html elements configurable via WebSettings. This patch introduces the setSpellCheckEnabledByDefault method in WebSettings to allow control over whether spellchecking should be enabled by default in spellcheck-capable html elements (e.g. text <input> elements and elements with the contenteditable="true" attribute). Currently the default behavior is that spellcheck is enabled. This patch does not actually change any defaults or functionality, instead this would happen at a later stage in a separate patch. For example on Android where we may want to change the default for performance reasons, or in Android WebView due to consistency considerations. BUG=583616, 629609 ========== to ========== Make default spellchecking behavior in html elements configurable via WebSettings. This patch introduces the setSpellCheckEnabledByDefault method in WebSettings to allow control over whether spellchecking should be enabled by default in spellcheck-capable html elements (e.g. text <input> elements and elements with the contenteditable="true" attribute). Currently the default behavior is that spellcheck is enabled. This patch does not actually change any defaults or functionality, instead this would happen at a later stage in a separate patch. For example on Android where we may want to change the default for performance reasons, or in Android WebView due to consistency considerations. BUG=583616, 629609 Committed: https://crrev.com/b0a6d1d8932f6d5a1bbdfb4a650e139d6557163c Cr-Commit-Position: refs/heads/master@{#421808} ==========
Message was sent while issue was closed.
Patchset 10 (id:??) landed as https://crrev.com/b0a6d1d8932f6d5a1bbdfb4a650e139d6557163c Cr-Commit-Position: refs/heads/master@{#421808} |
