Make default spellchecking behavior in html elements configurable via WebSettings.

third_party/WebKit/Source/core/dom/Element.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
  *           (C) 2007 Eric Seidel (eric@webkit.org)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 3190 matching lines @@
         switch (element->spellcheckAttributeState()) {
         case SpellcheckAttributeTrue:
             return true;
         case SpellcheckAttributeFalse:
             return false;
         case SpellcheckAttributeDefault:
             break;
         }
     }
 
+#if OS(ANDROID)
+    return false;

[Peter Beverloo, 2016/09/12 14:59:02]

This should probably be a decision made by the embedder, i.e. routed through
WebSettings?

[Rick Byers, 2016/09/14 15:21:00]

Yes, we avoid adding #ifdefs like this in Blink.  Eg. it lets us write tests for
both modes that run on all platforms rather than relying on running the tests on
Android (which we still don't do for many tests).

[timvolodine, 2016/09/14 17:16:31]

ok, sounds right, thanks for the suggestion Peter!
I've now implemented it via settings.

+#else
     return true;
+#endif
 }
 
 #if DCHECK_IS_ON()
 bool Element::fastAttributeLookupAllowed(const QualifiedName& name) const
 {
     if (name == HTMLNames::styleAttr)
         return false;
 
     if (isSVGElement())
         return !toSVGElement(this)->isAnimatableAttribute(name);
@@ skipping 596 matching lines @@
 
 DEFINE_TRACE_WRAPPERS(Element)
 {
     if (hasRareData()) {
         visitor->traceWrappers(elementRareData());
     }
     ContainerNode::traceWrappers(visitor);
 }
 
 } // namespace blink