Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2316303006: Make default spellchecking behavior in html elements configurable via WebSettings. (Closed)
Patch Set: make it configurable via settings Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | third_party/WebKit/Source/core/frame/Settings.in » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 3199 matching lines...) Expand 10 before | Expand all | Expand 10 after
3210 switch (element->spellcheckAttributeState()) { 3210 switch (element->spellcheckAttributeState()) {
3211 case SpellcheckAttributeTrue: 3211 case SpellcheckAttributeTrue:
3212 return true; 3212 return true;
3213 case SpellcheckAttributeFalse: 3213 case SpellcheckAttributeFalse:
3214 return false; 3214 return false;
3215 case SpellcheckAttributeDefault: 3215 case SpellcheckAttributeDefault:
3216 break; 3216 break;
3217 } 3217 }
3218 } 3218 }
3219 3219
3220 return true; 3220 return document().page()->settings().spellCheckEnabledByDefault();
Rick Byers 2016/09/15 20:28:09 I believe there are cases where page() could be nu
timvolodine 2016/09/22 17:52:57 Done.
3221 } 3221 }
3222 3222
3223 #if DCHECK_IS_ON() 3223 #if DCHECK_IS_ON()
3224 bool Element::fastAttributeLookupAllowed(const QualifiedName& name) const 3224 bool Element::fastAttributeLookupAllowed(const QualifiedName& name) const
3225 { 3225 {
3226 if (name == HTMLNames::styleAttr) 3226 if (name == HTMLNames::styleAttr)
3227 return false; 3227 return false;
3228 3228
3229 if (isSVGElement()) 3229 if (isSVGElement())
3230 return !toSVGElement(this)->isAnimatableAttribute(name); 3230 return !toSVGElement(this)->isAnimatableAttribute(name);
(...skipping 597 matching lines...) Expand 10 before | Expand all | Expand 10 after
3828 3828
3829 DEFINE_TRACE_WRAPPERS(Element) 3829 DEFINE_TRACE_WRAPPERS(Element)
3830 { 3830 {
3831 if (hasRareData()) { 3831 if (hasRareData()) {
3832 visitor->traceWrappers(elementRareData()); 3832 visitor->traceWrappers(elementRareData());
3833 } 3833 }
3834 ContainerNode::traceWrappers(visitor); 3834 ContainerNode::traceWrappers(visitor);
3835 } 3835 }
3836 3836
3837 } // namespace blink 3837 } // namespace blink
OLDNEW
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | third_party/WebKit/Source/core/frame/Settings.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698