Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2315643002: DO NOT SUBMIT: Allow selection change update before beginBatchEdit (Closed)

Created:
4 years, 3 months ago by Changwan Ryu
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow selection change update before beginBatchEdit Currently, selection changes immediately before beginBatchEdit() may be merged into batch edit selection update which happens at endBatchEdit(). The reason is that it takes round-trip time to get update from previous operation and if we increment mNumNestedBatchEdits in beginBatchEdit() before the update from renderer process arrives at browser process, then the update from operation will be ignored because mNumNestedBatchEdits > 0. This can be prevented if we block and update selection at outermost beginBatchEdit() call. BUG=643473

Patch Set 1 #

Patch Set 2 : fix tests #

Messages

Total messages: 13 (10 generated)
Changwan Ryu
4 years, 3 months ago (2016-09-06 08:57:27 UTC) #4
Changwan Ryu
This CL's tests are also fixed.
4 years, 3 months ago (2016-09-07 08:14:10 UTC) #9
Changwan Ryu
4 years, 3 months ago (2016-09-21 00:57:28 UTC) #12
There are additional benefits with an alternative solution
(https://codereview.chromium.org/2309983002/), so dropping this one.

Powered by Google App Engine
This is Rietveld 408576698