Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Issue 2315643002: DO NOT SUBMIT: Allow selection change update before beginBatchEdit (Closed)
Patch Set: fix tests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
index c931600cd206190a7f6b75ae2c69beb930b47502..fc05ccb2817f1c3e6abafecf9a486feb4bb98789 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
@@ -1326,28 +1326,30 @@ public class ImeTest extends ContentShellTestBase {
}));
}
- // Tests that the method call order is kept.
- // See crbug.com/601707 for details.
+ // Tests that the method call order is kept and get updates correctly.
+ // crbug.com/601707, crbug.com/643473
@MediumTest
@Feature({"TextInput"})
- public void testSetSelectionCommitTextOrder() throws Exception {
+ public void testAsynchronousSequence() throws Exception {
final ChromiumBaseInputConnection connection = mConnection;
runBlockingOnImeThread(new Callable<Void>() {
@Override
public Void call() {
+ connection.commitText("hi ", 1);
connection.beginBatchEdit();
connection.commitText("hello world", 1);
- connection.setSelection(6, 6);
- connection.deleteSurroundingText(0, 5);
+ connection.setSelection(9, 9);
+ connection.deleteSurroundingText(3, 8);
connection.commitText("'", 1);
connection.commitText("world", 1);
- connection.setSelection(7, 7);
+ connection.setSelection(10, 10);
connection.setComposingText("", 1);
connection.endBatchEdit();
return null;
}
});
- waitAndVerifyUpdateSelection(0, 7, 7, -1, -1);
+ waitAndVerifyUpdateSelection(0, 3, 3, -1, -1);
+ waitAndVerifyUpdateSelection(1, 10, 10, -1, -1);
}
private void performGo(TestCallbackHelperContainer testCallbackHelperContainer)
@@ -1654,7 +1656,6 @@ public class ImeTest extends ContentShellTestBase {
private void focusElementAndWaitForStateUpdate(String id)
throws InterruptedException, TimeoutException {
focusElement(id);
- waitAndVerifyUpdateSelection(0, 0, 0, -1, -1);
resetUpdateSelectionList();
}

Powered by Google App Engine
This is Rietveld 408576698