Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1998)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

Issue 2315643002: DO NOT SUBMIT: Allow selection change update before beginBatchEdit (Closed)
Patch Set: fix tests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java b/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java
index 2bcd30a2d52d7eeb529e397bd0adee5237b9e1c0..05dc2369cf0909bb5239303087e41d78361e34ad 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java
@@ -175,7 +175,7 @@ public class ThreadedInputConnection extends BaseInputConnection
}
private void processPendingInputStates() {
- if (DEBUG_LOGS) Log.w(TAG, "checkQueue");
+ if (DEBUG_LOGS) Log.w(TAG, "processPendingInputStates");
assertOnImeThread();
// Handle all the remaining states in the queue.
while (true) {
@@ -374,6 +374,7 @@ public class ThreadedInputConnection extends BaseInputConnection
public boolean beginBatchEdit() {
if (DEBUG_LOGS) Log.w(TAG, "beginBatchEdit [%b]", (mNumNestedBatchEdits == 0));
assertOnImeThread();
+ if (mNumNestedBatchEdits == 0) updateSelection(requestAndWaitForTextInputState());
mNumNestedBatchEdits++;
return true;
}
« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698