Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2315443004: Remove calls to deprecated MessageLoop methods in chrome. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, asvitkine+watch_chromium.org, oka+watch_chromium.org, browser-components-watch_chromium.org, dcheng, rginda+watch_chromium.org, fukino+watch_chromium.org, felt, miu+watch_chromium.org, extensions-reviews_chromium.org, achuith+watch_chromium.org, chromium-apps-reviews_chromium.org, alemate+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, yamaguchi+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, kalyank, gcasto+watchlist_chromium.org, oshima+watch_chromium.org, tfarina, jshin+watch_chromium.org, James Su, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in chrome. This CL (hopefully) removes all calls to these methods in chrome: - MessageLoop::PostTask - MessageLoop::PostDelayedTask - MessageLoop::DeleteSoon - MessageLoop::ReleaseSoon - MessageLoop::Run - MessageLoop::RunUntilIdle BUG=616447 R=sky@chromium.org Committed: https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f Cr-Commit-Position: refs/heads/master@{#417639}

Patch Set 1 #

Patch Set 2 : fix build error #

Patch Set 3 : self-review #

Patch Set 4 : fix build error #

Total comments: 2

Patch Set 5 : CR sky #18 #

Patch Set 6 : remove unused include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -115 lines) Patch
M chrome/app/mash/mash_runner.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/app_shim/chrome_main_app_mode_mac.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/download/download_manager_service_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider_extension_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/policy/device_quirks_policy_browsertest.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector_browsertest.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/policy/device_system_use_24hour_clock_browsertest.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/proxy_config_service_impl_unittest.cc View 7 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_browsertest.cc View 1 2 3 4 5 3 chunks +8 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/socket/udp_socket_unittest.cc View 3 chunks +17 lines, -14 lines 0 comments Download
M chrome/browser/extensions/extension_user_script_loader_unittest.cc View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/menu_manager_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/history/android/android_history_provider_service_unittest.cc View 1 2 13 chunks +30 lines, -15 lines 0 comments Download
M chrome/browser/history/android/sqlite_cursor_unittest.cc View 1 2 5 chunks +20 lines, -6 lines 0 comments Download
M chrome/browser/media/webrtc/desktop_media_list_ash_unittest.cc View 1 2 3 4 5 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/metrics/chromeos_metrics_provider_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/thumbnails/content_based_thumbnailing_algorithm_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 1 2 3 4 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/l10n_util_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/media/chrome_webrtc_log_message_delegate_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/tools/service_discovery_sniffer/service_discovery_sniffer.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 31 (25 generated)
fdoray
PTAL
4 years, 3 months ago (2016-09-08 15:08:55 UTC) #17
sky
LGTM https://codereview.chromium.org/2315443004/diff/60001/chrome/browser/extensions/activity_log/activity_log_browsertest.cc File chrome/browser/extensions/activity_log/activity_log_browsertest.cc (right): https://codereview.chromium.org/2315443004/diff/60001/chrome/browser/extensions/activity_log/activity_log_browsertest.cc#newcode48 chrome/browser/extensions/activity_log/activity_log_browsertest.cc:48: // This is to exit RunLoop (run_loop.Run()) below ...
4 years, 3 months ago (2016-09-08 17:54:33 UTC) #18
fdoray
https://codereview.chromium.org/2315443004/diff/60001/chrome/browser/extensions/activity_log/activity_log_browsertest.cc File chrome/browser/extensions/activity_log/activity_log_browsertest.cc (right): https://codereview.chromium.org/2315443004/diff/60001/chrome/browser/extensions/activity_log/activity_log_browsertest.cc#newcode48 chrome/browser/extensions/activity_log/activity_log_browsertest.cc:48: // This is to exit RunLoop (run_loop.Run()) below On ...
4 years, 3 months ago (2016-09-09 18:10:51 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315443004/100001
4 years, 3 months ago (2016-09-09 18:11:02 UTC) #28
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 3 months ago (2016-09-09 18:19:25 UTC) #29
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 18:21:07 UTC) #31
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f
Cr-Commit-Position: refs/heads/master@{#417639}

Powered by Google App Engine
This is Rietveld 408576698