chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc - Issue 2315443004: Remove calls to deprecated MessageLoop methods in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

Issue 2315443004: Remove calls to deprecated MessageLoop methods in chrome. (Closed)

Patch Set: remove unused include Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/shortcuts_provider_extension_unittest.cc ('k') | chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

diff --git a/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc b/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

index abc7a0fbf9372e038e147ae5df30d6bc71b79a00..9da84ffcab971562f728457f58caa4ec1c4c5894 100644

--- a/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

+++ b/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

@@ -12,6 +12,7 @@

#include "base/json/json_value_converter.h"

#include "base/json/json_writer.h"

#include "base/path_service.h"

+#include "base/run_loop.h"

#include "base/strings/string_piece.h"

#include "base/time/time.h"

#include "chrome/browser/browser_process.h"

@@ -410,14 +411,14 @@ class DriveTestVolume : public TestVolume {

fake_drive_service_->AddNewDirectory(

parent_id, target_name, drive::AddNewDirectoryOptions(),

google_apis::test_util::CreateCopyResultCallback(&error, &entry));

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

ASSERT_EQ(google_apis::HTTP_CREATED, error);

ASSERT_TRUE(entry);

fake_drive_service_->SetLastModifiedTime(

entry->file_id(), modification_time,

google_apis::test_util::CreateCopyResultCallback(&error, &entry));

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

ASSERT_TRUE(error == google_apis::HTTP_SUCCESS);

ASSERT_TRUE(entry);

CheckForUpdates();

@@ -443,14 +444,14 @@ class DriveTestVolume : public TestVolume {

fake_drive_service_->AddNewFile(

mime_type, content_data, parent_id, target_name, shared_with_me,

google_apis::test_util::CreateCopyResultCallback(&error, &entry));

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

ASSERT_EQ(google_apis::HTTP_CREATED, error);

ASSERT_TRUE(entry);

fake_drive_service_->SetLastModifiedTime(

entry->file_id(), modification_time,

google_apis::test_util::CreateCopyResultCallback(&error, &entry));

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

ASSERT_EQ(google_apis::HTTP_SUCCESS, error);

ASSERT_TRUE(entry);