Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: chrome/app_shim/chrome_main_app_mode_mac.mm

Issue 2315443004: Remove calls to deprecated MessageLoop methods in chrome. (Closed)
Patch Set: remove unused include Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // On Mac, one can't make shortcuts with command-line arguments. Instead, we 5 // On Mac, one can't make shortcuts with command-line arguments. Instead, we
6 // produce small app bundles which locate the Chromium framework and load it, 6 // produce small app bundles which locate the Chromium framework and load it,
7 // passing the appropriate data. This is the entry point into the framework for 7 // passing the appropriate data. This is the entry point into the framework for
8 // those app bundles. 8 // those app bundles.
9 9
10 #import <Cocoa/Cocoa.h> 10 #import <Cocoa/Cocoa.h>
11 #include <vector> 11 #include <vector>
12 12
13 #include "base/at_exit.h" 13 #include "base/at_exit.h"
14 #include "base/command_line.h" 14 #include "base/command_line.h"
15 #include "base/files/file_path.h" 15 #include "base/files/file_path.h"
16 #include "base/files/file_util.h" 16 #include "base/files/file_util.h"
17 #include "base/logging.h" 17 #include "base/logging.h"
18 #include "base/mac/bundle_locations.h" 18 #include "base/mac/bundle_locations.h"
19 #include "base/mac/foundation_util.h" 19 #include "base/mac/foundation_util.h"
20 #include "base/mac/launch_services_util.h" 20 #include "base/mac/launch_services_util.h"
21 #include "base/mac/mac_logging.h" 21 #include "base/mac/mac_logging.h"
22 #include "base/mac/mac_util.h" 22 #include "base/mac/mac_util.h"
23 #include "base/mac/scoped_nsautorelease_pool.h" 23 #include "base/mac/scoped_nsautorelease_pool.h"
24 #include "base/mac/scoped_nsobject.h" 24 #include "base/mac/scoped_nsobject.h"
25 #include "base/mac/sdk_forward_declarations.h" 25 #include "base/mac/sdk_forward_declarations.h"
26 #include "base/macros.h" 26 #include "base/macros.h"
27 #include "base/message_loop/message_loop.h" 27 #include "base/message_loop/message_loop.h"
28 #include "base/run_loop.h"
28 #include "base/strings/string_number_conversions.h" 29 #include "base/strings/string_number_conversions.h"
29 #include "base/strings/sys_string_conversions.h" 30 #include "base/strings/sys_string_conversions.h"
30 #include "base/threading/thread.h" 31 #include "base/threading/thread.h"
31 #include "chrome/common/chrome_constants.h" 32 #include "chrome/common/chrome_constants.h"
32 #include "chrome/common/chrome_paths.h" 33 #include "chrome/common/chrome_paths.h"
33 #include "chrome/common/chrome_switches.h" 34 #include "chrome/common/chrome_switches.h"
34 #include "chrome/common/mac/app_mode_common.h" 35 #include "chrome/common/mac/app_mode_common.h"
35 #include "chrome/common/mac/app_shim_messages.h" 36 #include "chrome/common/mac/app_shim_messages.h"
36 #include "chrome/grit/generated_resources.h" 37 #include "chrome/grit/generated_resources.h"
37 #include "ipc/ipc_channel_mojo.h" 38 #include "ipc/ipc_channel_mojo.h"
(...skipping 667 matching lines...) Expand 10 before | Expand all | Expand 10 after
705 } else { 706 } else {
706 // Chrome already running. Proceed to init. This could still fail if Chrome 707 // Chrome already running. Proceed to init. This could still fail if Chrome
707 // is still starting up or shutting down, but the process will exit quickly, 708 // is still starting up or shutting down, but the process will exit quickly,
708 // which is preferable to waiting for the Apple Event to timeout after one 709 // which is preferable to waiting for the Apple Event to timeout after one
709 // minute. 710 // minute.
710 main_message_loop.task_runner()->PostTask( 711 main_message_loop.task_runner()->PostTask(
711 FROM_HERE, 712 FROM_HERE,
712 base::Bind(&AppShimController::Init, base::Unretained(&controller))); 713 base::Bind(&AppShimController::Init, base::Unretained(&controller)));
713 } 714 }
714 715
715 main_message_loop.Run(); 716 base::RunLoop().Run();
716 return 0; 717 return 0;
717 } 718 }
OLDNEW
« no previous file with comments | « chrome/app/mash/mash_runner.cc ('k') | chrome/browser/android/download/download_manager_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698