Issue 231523002: Enable Error Console only for Unpacked extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 231523002: Enable Error Console only for Unpacked extensions (Closed)

Created:
6 years, 8 months ago by Devlin

Modified:
6 years, 8 months ago

Reviewers:
Finnur, not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable Error Console only for Unpacked extensions Having it enabled for all extensions leads to too much noise. Let's only have it for unpacked extensions for now. We have the backend implementation to turn it on or off for only particular extensions (and error severity), but we don't have the UI for it yet. In the interim, let's do this. BUG=360459 TBR=finnur@chromium.org (for small changes to extension_settings_handler.cc) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262861

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -8 lines)			Patch
	M	chrome/browser/extensions/api/developer_private/developer_private_api.cc	View		2 chunks	+6 lines, -4 lines	0 comments	Download
	M	chrome/browser/ui/webui/extensions/extension_settings_handler.cc	View		2 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

lgtm :( would really like to see this deployed out in the wild though. even ...

6 years, 8 months ago (2014-04-09 19:48:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/231523002/1

6 years, 8 months ago (2014-04-09 19:50:58 UTC) #4

Message was sent while issue was closed.

Change committed as 262861

Expand Messages | Collapse Messages