Enable Error Console only for Unpacked extensions

chrome/browser/extensions/api/developer_private/developer_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/developer_private/developer_private_api.h"
 
 #include "apps/app_load_service.h"
 #include "apps/app_restore_service.h"
 #include "apps/app_window.h"
 #include "apps/app_window_registry.h"
@@ skipping 42 matching lines @@
 #include "extensions/browser/extension_error.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/management_policy.h"
 #include "extensions/browser/view_type_utils.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension_resource.h"
 #include "extensions/common/extension_set.h"
 #include "extensions/common/install_warning.h"
+#include "extensions/common/manifest.h"
 #include "extensions/common/manifest_handlers/background_info.h"
 #include "extensions/common/manifest_handlers/incognito_info.h"
 #include "extensions/common/manifest_handlers/offline_enabled_info.h"
 #include "extensions/common/switches.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "net/base/net_util.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
@@ skipping 281 matching lines @@
     info->type = developer::ITEM_TYPE_THEME;
   } else if (item.is_extension()) {
     info->type = developer::ITEM_TYPE_EXTENSION;
   } else {
     NOTREACHED();
   }
 
   if (Manifest::IsUnpackedLocation(item.location())) {
     info->path.reset(
         new std::string(base::UTF16ToUTF8(item.path().LossyDisplayName())));
-    // If the ErrorConsole is enabled, get the errors for the extension and add
-    // them to the list. Otherwise, use the install warnings (using both is
-    // redundant).
+    // If the ErrorConsole is enabled and the extension is unpacked, use the
+    // more detailed errors from the ErrorConsole. Otherwise, use the install
+    // warnings (using both is redundant).
     ErrorConsole* error_console = ErrorConsole::Get(GetProfile());
-    if (error_console->IsEnabledForAppsDeveloperTools()) {
+    if (error_console->IsEnabledForAppsDeveloperTools() &&
+        item.location() == Manifest::UNPACKED) {
       const ErrorList& errors = error_console->GetErrorsForExtension(item.id());
       if (!errors.empty()) {
         for (ErrorList::const_iterator iter = errors.begin();
              iter != errors.end();
              ++iter) {
           switch ((*iter)->type()) {
             case ExtensionError::MANIFEST_ERROR:
               info->manifest_errors.push_back(
                   make_linked_ptr((*iter)->ToValue().release()));
               break;
@@ skipping 973 matching lines @@
   }
 
   error_ui_util::HandleOpenDevTools(dict);
 
   return true;
 }
 
 }  // namespace api
 
 }  // namespace extensions