Enable Error Console only for Unpacked extensions

chrome/browser/ui/webui/extensions/extension_settings_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
 
 #include "apps/app_load_service.h"
 #include "apps/app_restore_service.h"
 #include "apps/app_window.h"
 #include "apps/app_window_registry.h"
@@ skipping 64 matching lines @@
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/lazy_background_task_queue.h"
 #include "extensions/browser/management_policy.h"
 #include "extensions/browser/pref_names.h"
 #include "extensions/browser/view_type_utils.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_icon_set.h"
 #include "extensions/common/extension_set.h"
 #include "extensions/common/feature_switch.h"
+#include "extensions/common/manifest.h"
 #include "extensions/common/manifest_handlers/background_info.h"
 #include "extensions/common/manifest_handlers/incognito_info.h"
 #include "grit/browser_resources.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 
 using base::DictionaryValue;
@@ skipping 232 matching lines @@
     if (!warnings.empty()) {
       base::ListValue* warnings_list = new base::ListValue;
       for (std::vector<std::string>::const_iterator iter = warnings.begin();
            iter != warnings.end(); ++iter) {
         warnings_list->Append(base::Value::CreateStringValue(*iter));
       }
       extension_data->Set("warnings", warnings_list);
     }
   }
 
-  // If the ErrorConsole is enabled, get the errors for the extension and add
-  // them to the list. Otherwise, use the install warnings (using both is
-  // redundant).
+  // If the ErrorConsole is enabled and the extension is unpacked, use the more
+  // detailed errors from the ErrorConsole. Otherwise, use the install warnings
+  // (using both is redundant).
   ErrorConsole* error_console =
       ErrorConsole::Get(extension_service_->profile());
-  if (error_console->IsEnabledForChromeExtensionsPage()) {
+  if (error_console->IsEnabledForChromeExtensionsPage() &&
+      extension->location() == Manifest::UNPACKED) {
     const ErrorList& errors =
         error_console->GetErrorsForExtension(extension->id());
     if (!errors.empty()) {
       scoped_ptr<base::ListValue> manifest_errors(new base::ListValue);
       scoped_ptr<base::ListValue> runtime_errors(new base::ListValue);
       for (ErrorList::const_iterator iter = errors.begin();
            iter != errors.end(); ++iter) {
         if ((*iter)->type() == ExtensionError::MANIFEST_ERROR) {
           manifest_errors->Append((*iter)->ToValue().release());
         } else {  // Handle runtime error.
@@ skipping 976 matching lines @@
     const base::FilePath& path) {
   if (IndexOfLoadingPath(path) == -1)
     return;  // Not an extension we're tracking.
   if (retry)
     LoadUnpackedExtension(path);
   else
     RemoveLoadingPath(path);
 }
 
 }  // namespace extensions