Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in FrameSelection::selectedText

Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in FrameSelection::selectedText

BUG=590369
Committed: https://crrev.com/34509f0a41a7ef8893cbffa0967e551c67f87598
Cr-Commit-Position: refs/heads/master@{#417156}

[Xiaocheng, 2016-09-07 08:57:23]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 08:57:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-07 09:49:51]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org, yosin@chromium.org

[Xiaocheng, 2016-09-07 09:49:52]

PTAL.

[yosin_UTC9, 2016-09-07 09:58:25]

lgtm

https://codereview.chromium.org/2315223002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/FrameSelection.cpp (left):

https://codereview.chromium.org/2315223002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/FrameSelection.cpp:1074: if
(!isAvailable())
Could you have |DCHECK(isAvailable())|, just in case?

[Xiaocheng, 2016-09-07 10:01:56]

https://codereview.chromium.org/2315223002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/FrameSelection.cpp (left):

https://codereview.chromium.org/2315223002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/FrameSelection.cpp:1074: if
(!isAvailable())
On 2016/09/07 at 09:58:25, Yosi_UTC9 wrote:
> Could you have |DCHECK(isAvailable())|, just in case?

This |isAvailable()| check was added by myself a few days ago for hoisting the
layout update call from |plainText()|.

If anything goes wrong, it will be caught in |plainText()|.

[commit-bot: I haz the power, 2016-09-07 10:16:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 10:16:31]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-09-08 01:19:38]

lgtm

[Xiaocheng, 2016-09-08 01:39:25]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-09-08 01:39:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 01:44:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-08 01:47:50]

Description was changed from

==========
Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in
FrameSelection::selectedText

BUG=590369
==========

to

==========
Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in
FrameSelection::selectedText

BUG=590369

Committed: https://crrev.com/34509f0a41a7ef8893cbffa0967e551c67f87598
Cr-Commit-Position: refs/heads/master@{#417156}
==========

[commit-bot: I haz the power, 2016-09-08 01:47:51]

Patchset 1 (id:??) landed as
https://crrev.com/34509f0a41a7ef8893cbffa0967e551c67f87598
Cr-Commit-Position: refs/heads/master@{#417156}