Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in FrameSelection::selectedText

third_party/WebKit/Source/core/editing/FrameSelection.cpp

 /*
  * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 1053 matching lines @@
 
 String FrameSelection::selectedHTMLForClipboard() const
 {
     const VisibleSelectionInFlatTree& visibleSelection = this->visibleSelection<EditingInFlatTreeStrategy>();
     const EphemeralRangeInFlatTree& range = visibleSelection.toNormalizedEphemeralRange();
     return createMarkup(range.startPosition(), range.endPosition(), AnnotateForInterchange, ConvertBlocksToInlines::NotConvert, ResolveNonLocalURLs);
 }
 
 String FrameSelection::selectedText(TextIteratorBehavior behavior) const
 {
-    if (!isAvailable())

[yosin_UTC9, 2016/09/07 09:58:25]

Could you have |DCHECK(isAvailable())|, just in case?

[Xiaocheng, 2016/09/07 10:01:56]

This |isAvailable()| check was added by myself a few days ago for hoisting the
layout update call from |plainText()|.

If anything goes wrong, it will be caught in |plainText()|.

-        return emptyString();
-
-    // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
-    // needs to be audited.  See http://crbug.com/590369 for more details.
-    m_document->updateStyleAndLayoutIgnorePendingStylesheets();
-
     return extractSelectedText(*this, behavior);
 }
 
 String FrameSelection::selectedTextForClipboard() const
 {
     if (m_frame->settings() && m_frame->settings()->selectionIncludesAltImageText())
         return extractSelectedText(*this, TextIteratorEmitsImageAltText);
     return extractSelectedText(*this, TextIteratorDefaultBehavior);
 }
 
@@ skipping 288 matching lines @@
 
 void showTree(const blink::FrameSelection* sel)
 {
     if (sel)
         sel->showTreeForThis();
     else
         LOG(INFO) << "Cannot showTree for <null> FrameSelection.";
 }
 
 #endif