third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 2315223002: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in FrameSelection::selectedText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2315223002: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in FrameSelection::selectedText (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 306cafeb0070d0079fe460c794ddffa23187b071..e3d6a046e39c4c26f323abb9358a596ee941b643 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -1117,6 +1117,10 @@ WebString WebLocalFrameImpl::selectionAsText() const

if (pluginContainer)

return pluginContainer->plugin()->selectionAsText();

+ // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets

+ // needs to be audited. See http://crbug.com/590369 for more details.

+ frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();

String text = frame()->selection().selectedText(TextIteratorEmitsObjectReplacementCharacter);

#if OS(WIN)

replaceNewlinesWithWindowsStyleNewlines(text);