Fix all Performance and Bug-Prone patterns in quic/core. No functional change. Not flag protected.

net/quic/core/quic_client_promised_info_test.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/core/quic_client_promised_info.h"
 
 #include <memory>
 
 #include "base/macros.h"
 #include "base/scoped_ptr.h"
@@ skipping 253 matching lines @@
 }
 
 TEST_F(QuicClientPromisedInfoTest, PushPromiseVaryWaits) {
   ReceivePromise(promise_id_);
 
   QuicClientPromisedInfo* promised = session_.GetPromisedById(promise_id_);
   ASSERT_NE(promised, nullptr);
 
   // Now initiate rendezvous.
   PushPromiseDelegate delegate(/*match=*/true);
-  promised->HandleClientRequest(std::move(client_request_), &delegate);
+  promised->HandleClientRequest(client_request_, &delegate);
 
   // Promise is still there, waiting for response.
   EXPECT_NE(session_.GetPromisedById(promise_id_), nullptr);
 
   // Send Response, should trigger promise validation and complete rendezvous
   QuicSpdyClientStream* promise_stream = static_cast<QuicSpdyClientStream*>(
       session_.GetOrCreateStream(promise_id_));
   ASSERT_NE(promise_stream, nullptr);
   promise_stream->OnStreamHeaders(headers_string_);
   promise_stream->OnStreamHeadersComplete(false, headers_string_.size());
@@ skipping 11 matching lines @@
   QuicSpdyClientStream* promise_stream = static_cast<QuicSpdyClientStream*>(
       session_.GetOrCreateStream(promise_id_));
   ASSERT_NE(promise_stream, nullptr);
 
   // Send Response, should trigger promise validation and complete rendezvous
   promise_stream->OnStreamHeaders(headers_string_);
   promise_stream->OnStreamHeadersComplete(false, headers_string_.size());
 
   // Now initiate rendezvous.
   PushPromiseDelegate delegate(/*match=*/true);
-  promised->HandleClientRequest(std::move(client_request_), &delegate);
+  promised->HandleClientRequest(client_request_, &delegate);
 
   // Promise is gone
   EXPECT_EQ(session_.GetPromisedById(promise_id_), nullptr);
   // Have a push stream
   EXPECT_TRUE(delegate.rendezvous_fired());
 
   EXPECT_NE(delegate.rendezvous_stream(), nullptr);
 }
 
 TEST_F(QuicClientPromisedInfoTest, PushPromiseWaitCancels) {
   ReceivePromise(promise_id_);
 
   QuicClientPromisedInfo* promised = session_.GetPromisedById(promise_id_);
   ASSERT_NE(promised, nullptr);
 
   // Now initiate rendezvous.
   PushPromiseDelegate delegate(/*match=*/true);
-  promised->HandleClientRequest(std::move(client_request_), &delegate);
+  promised->HandleClientRequest(client_request_, &delegate);
 
   // Promise is still there, waiting for response.
   EXPECT_NE(session_.GetPromisedById(promise_id_), nullptr);
 
   // Create response stream, but no data yet.
   session_.GetOrCreateStream(promise_id_);
 
   // Fire the alarm that will cancel the promised stream.
   EXPECT_CALL(session_, CloseStream(promise_id_));
   EXPECT_CALL(*connection_,
@@ skipping 18 matching lines @@
   promise_stream->OnStreamHeaders(headers_string_);
   promise_stream->OnStreamHeadersComplete(false, headers_string_.size());
 
   EXPECT_CALL(session_, CloseStream(promise_id_));
   EXPECT_CALL(*connection_,
               SendRstStream(promise_id_, QUIC_STREAM_PEER_GOING_AWAY, 0));
   session_.SendRstStream(promise_id_, QUIC_STREAM_PEER_GOING_AWAY, 0);
 
   // Now initiate rendezvous.
   PushPromiseDelegate delegate(/*match=*/true);
-  EXPECT_EQ(
-      promised->HandleClientRequest(std::move(client_request_), &delegate),
-      QUIC_FAILURE);
+  EXPECT_EQ(promised->HandleClientRequest(client_request_, &delegate),
+            QUIC_FAILURE);
 
   // Got an indication of the stream failure, client should retry
   // request.
   EXPECT_FALSE(delegate.rendezvous_fired());
   EXPECT_EQ(delegate.rendezvous_stream(), nullptr);
 
   // Promise is gone
   EXPECT_EQ(session_.GetPromisedById(promise_id_), nullptr);
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace net