Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2314863002: Revert of Reland Compile under-invalidation checking in all builds (Closed)

Created:
4 years, 3 months ago by Xianzhu
Modified:
4 years, 3 months ago
Reviewers:
pdr.
CC:
ajuma+watch_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland Compile under-invalidation checking in all builds (patchset #4 id:60001 of https://codereview.chromium.org/2301303002/ ) Reason for revert: This should be landed to discover under-invalidations. If any test hit this, we should mark the test fail instead of reverting this. Original issue's description: > Reland Compile under-invalidation checking in all builds > > This relands https://codereview.chromium.org/2299223002 which was > reverted because of random pixel under-invalidations. > > Now clear the bitmaps before drawing the pictures. > > BTW changed the error indication color from solid red to translucent > magenta to distinguish from the normal red pixels in test results. > > > This will let the tests having under-invalidation issues produce the > > same result on all builds, so enable us to rebaseline the tests with > > failure results. In this way we can track either regressions and > > progressions instead of ignoring the tests. > > > > BUG=619103 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > > > Review-Url: https://codereview.chromium.org/2299223002 > > Cr-Commit-Position: refs/heads/master@{#416060} > > BUG=619103 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > R=pdr@chromium.org TBR=pdr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=619103

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -87 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/repaint/page-scale-repaint.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/obscured-background-no-repaint.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/resources/window-resize-repaint.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/resources/run-after-layout-and-paint.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.h View 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 11 chunks +20 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp View 3 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 22 chunks +40 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp View 20 chunks +29 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/TransformDisplayItem.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Xianzhu
Created Revert of Reland Compile under-invalidation checking in all builds
4 years, 3 months ago (2016-09-06 16:05:32 UTC) #1
Xianzhu
4 years, 3 months ago (2016-09-06 16:07:32 UTC) #2
On 2016/09/06 16:05:32, Xianzhu wrote:
> Created Revert of Reland Compile under-invalidation checking in all builds

This is wrong. We should not revert this. We should revert the revert of reland.

Powered by Google App Engine
This is Rietveld 408576698