Compile under-invalidation checking in all builds

Compile under-invalidation checking in all builds

This will let the tests having under-invalidation issues produce the
same result on all builds, so enable us to rebaseline the tests with
failure results. In this way we can track either regressions and
progressions instead of ignoring the tests.

BUG=619103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e
Cr-Commit-Position: refs/heads/master@{#416060}

[Xianzhu, 2016-09-01 16:34:25]

Description was changed from

==========
Compile under-invalidation checking in all builds

This will let the tests having under-invalidation issues produce the
same result on all builds, so enable us to rebaseline the tests with
failure results. In this way we can track either regressions and
progressions instead of ignoring the tests.
==========

to

==========
Compile under-invalidation checking in all builds

This will let the tests having under-invalidation issues produce the
same result on all builds, so enable us to rebaseline the tests with
failure results. In this way we can track either regressions and
progressions instead of ignoring the tests.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-09-01 16:35:42]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2016-09-01 16:48:52]

https://codereview.chromium.org/2299223002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp (right):

https://codereview.chromium.org/2299223002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp:95: Region
paintInvalidationRegionSinceLastPaint;
Region is a huge datastructure. Do we need to worry about that?

https://codereview.chromium.org/2299223002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp:96:
Vector<UnderPaintInvalidation> underPaintInvalidations;
To save memory can you make this vector small by default?

https://codereview.chromium.org/2299223002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/PaintController.h
(right):

https://codereview.chromium.org/2299223002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/PaintController.h:214: //
(when RuntimeEnabledFeatures::slimmingPaintUnderInvalidationCheckingEnabled).
Nit: paintUnderInvalidationCheckingEnabled

https://codereview.chromium.org/2299223002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/PaintController.h:267: #ifndef
NDEBUG
Why did this change to ndebug? (here, and elsewhere in this patch)

[Xianzhu, 2016-09-01 17:00:03]

https://codereview.chromium.org/2299223002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp (right):

https://codereview.chromium.org/2299223002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp:95: Region
paintInvalidationRegionSinceLastPaint;
On 2016/09/01 16:48:52, pdr. wrote:
> Region is a huge datastructure. Do we need to worry about that?

I don't think we need to worry memory because the structure is allocated only
when paintUnderInvalidationChecking is enabled or we are tracking paint
invalidations, at most one for each GraphicsLayer.

https://codereview.chromium.org/2299223002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/PaintController.h
(right):

https://codereview.chromium.org/2299223002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/PaintController.h:214: //
(when RuntimeEnabledFeatures::slimmingPaintUnderInvalidationCheckingEnabled).
On 2016/09/01 16:48:52, pdr. wrote:
> Nit: paintUnderInvalidationCheckingEnabled

Done.

https://codereview.chromium.org/2299223002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/PaintController.h:267: #ifndef
NDEBUG
On 2016/09/01 16:48:52, pdr. wrote:
> Why did this change to ndebug? (here, and elsewhere in this patch)

They are really for debugging, not for checking any conditions. Changed this
because it made it easy to find DCHECK_IS_ON()'s to remove.

[pdr., 2016-09-01 17:08:10]

On 2016/09/01 at 17:00:03, wangxianzhu wrote:
>
https://codereview.chromium.org/2299223002/diff/1/third_party/WebKit/Source/p...
> File third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp (right):
> 
>
https://codereview.chromium.org/2299223002/diff/1/third_party/WebKit/Source/p...
> third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp:95: Region
paintInvalidationRegionSinceLastPaint;
> On 2016/09/01 16:48:52, pdr. wrote:
> > Region is a huge datastructure. Do we need to worry about that?
> 
> I don't think we need to worry memory because the structure is allocated only
when paintUnderInvalidationChecking is enabled or we are tracking paint
invalidations, at most one for each GraphicsLayer.
> 
>
https://codereview.chromium.org/2299223002/diff/1/third_party/WebKit/Source/p...
> File third_party/WebKit/Source/platform/graphics/paint/PaintController.h
(right):
> 
>
https://codereview.chromium.org/2299223002/diff/1/third_party/WebKit/Source/p...
> third_party/WebKit/Source/platform/graphics/paint/PaintController.h:214: //
(when RuntimeEnabledFeatures::slimmingPaintUnderInvalidationCheckingEnabled).
> On 2016/09/01 16:48:52, pdr. wrote:
> > Nit: paintUnderInvalidationCheckingEnabled
> 
> Done.
> 
>
https://codereview.chromium.org/2299223002/diff/1/third_party/WebKit/Source/p...
> third_party/WebKit/Source/platform/graphics/paint/PaintController.h:267:
#ifndef NDEBUG
> On 2016/09/01 16:48:52, pdr. wrote:
> > Why did this change to ndebug? (here, and elsewhere in this patch)
> 
> They are really for debugging, not for checking any conditions. Changed this
because it made it easy to find DCHECK_IS_ON()'s to remove.

LGTM

[Xianzhu, 2016-09-01 17:10:32]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-09-01 17:10:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 18:46:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 18:46:18]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[Xianzhu, 2016-09-01 19:06:14]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-09-01 19:06:15]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2299223002/#ps40001
(title: "Update FlagExpectations/enable-slimming-paint-v2")

[commit-bot: I haz the power, 2016-09-01 19:06:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-09-01 19:22:46]

Description was changed from

==========
Compile under-invalidation checking in all builds

This will let the tests having under-invalidation issues produce the
same result on all builds, so enable us to rebaseline the tests with
failure results. In this way we can track either regressions and
progressions instead of ignoring the tests.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Compile under-invalidation checking in all builds

This will let the tests having under-invalidation issues produce the
same result on all builds, so enable us to rebaseline the tests with
failure results. In this way we can track either regressions and
progressions instead of ignoring the tests.

BUG=619103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-09-01 19:25:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 19:26:00]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2016-09-01 19:39:01]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-09-01 19:39:01]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2299223002/#ps60001
(title: "Resolve conflict")

[commit-bot: I haz the power, 2016-09-01 19:39:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 21:28:17]

Description was changed from

==========
Compile under-invalidation checking in all builds

This will let the tests having under-invalidation issues produce the
same result on all builds, so enable us to rebaseline the tests with
failure results. In this way we can track either regressions and
progressions instead of ignoring the tests.

BUG=619103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Compile under-invalidation checking in all builds

This will let the tests having under-invalidation issues produce the
same result on all builds, so enable us to rebaseline the tests with
failure results. In this way we can track either regressions and
progressions instead of ignoring the tests.

BUG=619103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-09-01 21:28:19]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-01 21:29:56]

Description was changed from

==========
Compile under-invalidation checking in all builds

This will let the tests having under-invalidation issues produce the
same result on all builds, so enable us to rebaseline the tests with
failure results. In this way we can track either regressions and
progressions instead of ignoring the tests.

BUG=619103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Compile under-invalidation checking in all builds

This will let the tests having under-invalidation issues produce the
same result on all builds, so enable us to rebaseline the tests with
failure results. In this way we can track either regressions and
progressions instead of ignoring the tests.

BUG=619103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e
Cr-Commit-Position: refs/heads/master@{#416060}
==========

[commit-bot: I haz the power, 2016-09-01 21:29:57]

Patchset 4 (id:??) landed as
https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e
Cr-Commit-Position: refs/heads/master@{#416060}

[Xianzhu, 2016-09-01 23:06:24]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2306783002/ by wangxianzhu@chromium.org.

The reason for reverting is: On Mac and Windows strange pixel under
invalidations are reported, e.g.:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win10/142....