Remove calls to deprecated MessageLoop methods in chromeos.

Remove calls to deprecated MessageLoop methods in chromeos.

This CL (hopefully) removes all calls to these methods in chromeos:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=oshima@chromium.org

Committed: https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544
Cr-Commit-Position: refs/heads/master@{#418234}

[fdoray, 2016-09-06 20:22:26]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 20:24:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 21:08:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 21:08:50]

Dry run: This issue passed the CQ dry run.

[fdoray, 2016-09-06 21:56:17]

fdoray@chromium.org changed reviewers:
+ armansito@chromium.org

[fdoray, 2016-09-06 21:56:17]

oshima@: PTAL

armansito@: Please review changes in chromeos/network

[armansito, 2016-09-06 22:04:32]

https://codereview.chromium.org/2314853004/diff/1/chromeos/network/geolocatio...
File chromeos/network/geolocation_handler_unittest.cc (right):

https://codereview.chromium.org/2314853004/diff/1/chromeos/network/geolocatio...
chromeos/network/geolocation_handler_unittest.cc:69: base::MessageLoopForUI
message_loop_;
Shouldn't this be removed as well?

https://codereview.chromium.org/2314853004/diff/1/chromeos/network/managed_ne...
File chromeos/network/managed_network_configuration_handler_unittest.cc (right):

https://codereview.chromium.org/2314853004/diff/1/chromeos/network/managed_ne...
chromeos/network/managed_network_configuration_handler_unittest.cc:389:
base::MessageLoop message_loop_;
Is this still needed? It doesn't seem to get used.

https://codereview.chromium.org/2314853004/diff/1/chromeos/network/network_co...
File chromeos/network/network_configuration_handler_unittest.cc (right):

https://codereview.chromium.org/2314853004/diff/1/chromeos/network/network_co...
chromeos/network/network_configuration_handler_unittest.cc:301:
base::MessageLoopForUI message_loop_;
ditto

https://codereview.chromium.org/2314853004/diff/1/chromeos/network/network_de...
File chromeos/network/network_device_handler_unittest.cc (right):

https://codereview.chromium.org/2314853004/diff/1/chromeos/network/network_de...
chromeos/network/network_device_handler_unittest.cc:106: base::MessageLoopForUI
message_loop_;
ditto

https://codereview.chromium.org/2314853004/diff/1/chromeos/network/network_sm...
File chromeos/network/network_sms_handler_unittest.cc (right):

https://codereview.chromium.org/2314853004/diff/1/chromeos/network/network_sm...
chromeos/network/network_sms_handler_unittest.cc:91: base::MessageLoopForUI
message_loop_;
ditto

https://codereview.chromium.org/2314853004/diff/1/chromeos/network/network_st...
File chromeos/network/network_state_handler_unittest.cc (right):

https://codereview.chromium.org/2314853004/diff/1/chromeos/network/network_st...
chromeos/network/network_state_handler_unittest.cc:267: base::MessageLoopForUI
message_loop_;
ditto

https://codereview.chromium.org/2314853004/diff/1/chromeos/network/prohibited...
File chromeos/network/prohibited_technologies_handler_unittest.cc (right):

https://codereview.chromium.org/2314853004/diff/1/chromeos/network/prohibited...
chromeos/network/prohibited_technologies_handler_unittest.cc:128:
base::MessageLoopForUI message_loop_;
ditto

https://codereview.chromium.org/2314853004/diff/1/chromeos/network/shill_prop...
File chromeos/network/shill_property_handler_unittest.cc (right):

https://codereview.chromium.org/2314853004/diff/1/chromeos/network/shill_prop...
chromeos/network/shill_property_handler_unittest.cc:288: base::MessageLoopForUI
message_loop_;
ditto

[fdoray, 2016-09-07 13:03:49]

PTAnL

https://codereview.chromium.org/2314853004/diff/1/chromeos/network/geolocatio...
File chromeos/network/geolocation_handler_unittest.cc (right):

https://codereview.chromium.org/2314853004/diff/1/chromeos/network/geolocatio...
chromeos/network/geolocation_handler_unittest.cc:69: base::MessageLoopForUI
message_loop_;
On 2016/09/06 22:04:32, armansito wrote:
> Shouldn't this be removed as well?

No. A base::RunLoop must be instantiated within the scope of a
MessageLoop(ForUI|ForIO).

https://codereview.chromium.org/2314853004/diff/1/chromeos/network/managed_ne...
File chromeos/network/managed_network_configuration_handler_unittest.cc (right):

https://codereview.chromium.org/2314853004/diff/1/chromeos/network/managed_ne...
chromeos/network/managed_network_configuration_handler_unittest.cc:389:
base::MessageLoop message_loop_;
On 2016/09/06 22:04:32, armansito wrote:
> Is this still needed? It doesn't seem to get used.

ditto

https://codereview.chromium.org/2314853004/diff/1/chromeos/network/network_co...
File chromeos/network/network_configuration_handler_unittest.cc (right):

https://codereview.chromium.org/2314853004/diff/1/chromeos/network/network_co...
chromeos/network/network_configuration_handler_unittest.cc:301:
base::MessageLoopForUI message_loop_;
On 2016/09/06 22:04:32, armansito wrote:
> ditto

ditto

[fdoray, 2016-09-09 14:20:09]

ping

[oshima, 2016-09-13 01:36:05]

lgtm with nits

https://codereview.chromium.org/2314853004/diff/1/chromeos/geolocation/simple...
File chromeos/geolocation/simple_geolocation_unittest.cc (right):

https://codereview.chromium.org/2314853004/diff/1/chromeos/geolocation/simple...
chromeos/geolocation/simple_geolocation_unittest.cc:189:
std::unique_ptr<base::RunLoop> message_loop_runner_;
can you clean up this too?

(and one in timezone_unittest.cc)

[armansito, 2016-09-13 02:04:58]

lgtm

[fdoray, 2016-09-13 13:12:49]

https://codereview.chromium.org/2314853004/diff/1/chromeos/geolocation/simple...
File chromeos/geolocation/simple_geolocation_unittest.cc (right):

https://codereview.chromium.org/2314853004/diff/1/chromeos/geolocation/simple...
chromeos/geolocation/simple_geolocation_unittest.cc:189:
std::unique_ptr<base::RunLoop> message_loop_runner_;
On 2016/09/13 01:36:05, oshima wrote:
> can you clean up this too?
> 
> (and one in timezone_unittest.cc)

Still used at lines 173, 177, 178.
Same thing in timezone_unittest.cc.

[fdoray, 2016-09-13 13:12:57]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-09-13 13:13:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 14:12:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-13 14:14:49]

Description was changed from

==========
Remove calls to deprecated MessageLoop methods in chromeos.

This CL (hopefully) removes all calls to these methods in chromeos:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=oshima@chromium.org
==========

to

==========
Remove calls to deprecated MessageLoop methods in chromeos.

This CL (hopefully) removes all calls to these methods in chromeos:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=oshima@chromium.org

Committed: https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544
Cr-Commit-Position: refs/heads/master@{#418234}
==========

[commit-bot: I haz the power, 2016-09-13 14:14:51]

Patchset 1 (id:??) landed as
https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544
Cr-Commit-Position: refs/heads/master@{#418234}