Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: chromeos/dbus/shill_third_party_vpn_driver_client_unittest.cc

Issue 2314853004: Remove calls to deprecated MessageLoop methods in chromeos. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/shill_third_party_vpn_driver_client_unittest.cc
diff --git a/chromeos/dbus/shill_third_party_vpn_driver_client_unittest.cc b/chromeos/dbus/shill_third_party_vpn_driver_client_unittest.cc
index 99f40f5218428e6ac1ff23ad7d556546b0020d9d..7a5cb89750dd20e5c9a5c63a5ac43a59889edbbc 100644
--- a/chromeos/dbus/shill_third_party_vpn_driver_client_unittest.cc
+++ b/chromeos/dbus/shill_third_party_vpn_driver_client_unittest.cc
@@ -8,6 +8,7 @@
#include <string>
#include "base/bind.h"
+#include "base/run_loop.h"
#include "chromeos/dbus/shill_client_unittest_base.h"
#include "chromeos/dbus/shill_third_party_vpn_driver_client.h"
#include "chromeos/dbus/shill_third_party_vpn_observer.h"
@@ -44,7 +45,7 @@ class ShillThirdPartyVpnDriverClientTest : public ShillClientUnittestBase {
client_.reset(ShillThirdPartyVpnDriverClient::Create());
client_->Init(mock_bus_.get());
// Run the message loop to run the signal connection result callback.
- message_loop_.RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
}
void TearDown() override { ShillClientUnittestBase::TearDown(); }
@@ -122,7 +123,7 @@ TEST_F(ShillThirdPartyVpnDriverClientTest, PlatformSignal) {
testing::Mock::VerifyAndClearExpectations(&observer);
- message_loop_.RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
}
TEST_F(ShillThirdPartyVpnDriverClientTest, SetParameters) {
@@ -148,7 +149,7 @@ TEST_F(ShillThirdPartyVpnDriverClientTest, SetParameters) {
base::Unretained(this)),
base::Bind(&Failure));
- message_loop_.RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
}
TEST_F(ShillThirdPartyVpnDriverClientTest, UpdateConnectionState) {
@@ -167,7 +168,7 @@ TEST_F(ShillThirdPartyVpnDriverClientTest, UpdateConnectionState) {
base::Unretained(this)),
base::Bind(&Failure));
- message_loop_.RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
}
TEST_F(ShillThirdPartyVpnDriverClientTest, SendPacket) {
@@ -189,7 +190,7 @@ TEST_F(ShillThirdPartyVpnDriverClientTest, SendPacket) {
base::Unretained(this)),
base::Bind(&Failure));
- message_loop_.RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
}
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698