Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: chromeos/dbus/shill_ipconfig_client_unittest.cc

Issue 2314853004: Remove calls to deprecated MessageLoop methods in chromeos. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/shill_ipconfig_client_unittest.cc
diff --git a/chromeos/dbus/shill_ipconfig_client_unittest.cc b/chromeos/dbus/shill_ipconfig_client_unittest.cc
index cf2b761fbb4d6c9365aa061d74e9e56e6b443fa1..c559f965ee677627b683e6eebae7b07e8abde02d 100644
--- a/chromeos/dbus/shill_ipconfig_client_unittest.cc
+++ b/chromeos/dbus/shill_ipconfig_client_unittest.cc
@@ -5,6 +5,7 @@
#include <stdint.h>
#include "base/bind.h"
+#include "base/run_loop.h"
#include "base/values.h"
#include "chromeos/dbus/shill_client_unittest_base.h"
#include "chromeos/dbus/shill_ipconfig_client.h"
@@ -38,7 +39,7 @@ class ShillIPConfigClientTest : public ShillClientUnittestBase {
client_.reset(ShillIPConfigClient::Create());
client_->Init(mock_bus_.get());
// Run the message loop to run the signal connection result callback.
- message_loop_.RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
}
void TearDown() override { ShillClientUnittestBase::TearDown(); }
@@ -117,7 +118,7 @@ TEST_F(ShillIPConfigClientTest, GetProperties) {
client_->GetProperties(dbus::ObjectPath(kExampleIPConfigPath),
base::Bind(&ExpectDictionaryValueResult, &value));
// Run the message loop.
- message_loop_.RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
}
TEST_F(ShillIPConfigClientTest, SetProperty) {
@@ -139,7 +140,7 @@ TEST_F(ShillIPConfigClientTest, SetProperty) {
value,
base::Bind(&ExpectNoResultValue));
// Run the message loop.
- message_loop_.RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
}
TEST_F(ShillIPConfigClientTest, ClearProperty) {
@@ -156,7 +157,7 @@ TEST_F(ShillIPConfigClientTest, ClearProperty) {
shill::kAddressProperty,
base::Bind(&ExpectNoResultValue));
// Run the message loop.
- message_loop_.RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
}
TEST_F(ShillIPConfigClientTest, Remove) {
@@ -172,7 +173,7 @@ TEST_F(ShillIPConfigClientTest, Remove) {
base::Bind(&ExpectNoResultValue));
// Run the message loop.
- message_loop_.RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
}
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698