Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2314843003: PPC [heap]: Increase size of the compiled source object (Closed)

Created:
4 years, 3 months ago by JaideepBajwa
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, JoranSiu, john.yan, michael_dawson, MTBrandyberry
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC [heap]: Increase size of the compiled source object On PPC the testcase CodeSerializerLargeCodeObject fails as the object gets allocated in the code_space section of the heap. This is because the code_space gets expanded successfully to 1 page size (4MB on PPC) and can accommodate the object (size=3784608 bytes). Increasing size of the compiled source to (5096192 bytes) so that code_space is not expanded and the space is allocated in the Large Object space of the heap. Testcase was added as part of https://codereview.chromium.org/2226233002 R=mstarzinger@chromium.org, bmeurer@chromium.org BUG= LOG=N Committed: https://crrev.com/9908c589de98b7d7dd7a9599baaf37aa1ced0f5b Cr-Commit-Position: refs/heads/master@{#39252}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/cctest/test-serialize.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
JaideepBajwa
PTAL
4 years, 3 months ago (2016-09-06 22:28:32 UTC) #1
Michael Starzinger
LGTM if runtime is still acceptable (under 30 seconds) in all variants.
4 years, 3 months ago (2016-09-07 07:38:54 UTC) #2
JaideepBajwa
On 2016/09/07 07:38:54, Michael Starzinger wrote: > LGTM if runtime is still acceptable (under 30 ...
4 years, 3 months ago (2016-09-07 13:51:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314843003/1
4 years, 3 months ago (2016-09-07 13:51:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 14:16:54 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 14:17:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9908c589de98b7d7dd7a9599baaf37aa1ced0f5b
Cr-Commit-Position: refs/heads/master@{#39252}

Powered by Google App Engine
This is Rietveld 408576698