Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2226233002: [test] Speedup serializer test for large code objects. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_interpreter-preserve-bytecode-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Speedup serializer test for large code objects. R=yangguo@chromium.org TEST=cctest/test-serialize/CodeSerializerLargeCodeObject Committed: https://crrev.com/9b6d753170f9a0421b9a6788b355f5096e8981ac Cr-Commit-Position: refs/heads/master@{#38489}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -27 lines) Patch
M test/cctest/cctest.status View 5 chunks +0 lines, -23 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Michael Starzinger
This is the new timing on my machine: --- Total time: 00:09.648 --- 1 (00:09.615) ...
4 years, 4 months ago (2016-08-09 11:41:00 UTC) #1
Benedikt Meurer
Nice, LGTM.
4 years, 4 months ago (2016-08-09 11:54:06 UTC) #5
Yang
On 2016/08/09 11:54:06, Benedikt Meurer wrote: > Nice, LGTM. lgtm.
4 years, 4 months ago (2016-08-09 12:04:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226233002/20001
4 years, 4 months ago (2016-08-09 12:15:17 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-09 12:16:52 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 12:17:06 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9b6d753170f9a0421b9a6788b355f5096e8981ac
Cr-Commit-Position: refs/heads/master@{#38489}

Powered by Google App Engine
This is Rietveld 408576698