Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 23146008: Changed names of parameters of double.parse in patches to match change in external signature. (Closed)

Created:
7 years, 4 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 4 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Changed names of parameters of double.parse in patches to match change in external signature. Committed: https://code.google.com/p/dart/source/detail?r=26273

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M runtime/lib/double_patch.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/lib/core_patch.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
TBR
7 years, 4 months ago (2013-08-16 12:41:10 UTC) #1
Lasse Reichstein Nielsen
Committed patchset #1 manually as r26273 (presubmit successful).
7 years, 4 months ago (2013-08-16 12:41:15 UTC) #2
Søren Gjesse
7 years, 4 months ago (2013-08-16 12:57:22 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698