Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2314423004: Fix checkdeps warnings due to duplicate JUnit test names (Closed)

Created:
4 years, 3 months ago by johnme
Modified:
4 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, Peter Beverloo, kalyank, mlamouri+watch-notifications_chromium.org, sadrul, awdf+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix checkdeps warnings due to duplicate JUnit test names This patch fixes the following warnings emitted by buildtools/checkdeps/checkdeps.py by renaming the tests with duplicate names: WARNING: multiple definitions of org.chromium.chrome.browser.crash.LogcatExtractionCallableTest: chrome/android/junit/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java WARNING: multiple definitions of org.chromium.chrome.browser.payments.CurrencyStringFormatterTest: chrome/android/junit/src/org/chromium/chrome/browser/payments/CurrencyStringFormatterTest.java chrome/android/javatests/src/org/chromium/chrome/browser/payments/CurrencyStringFormatterTest.java WARNING: multiple definitions of org.chromium.chrome.browser.notifications.NotificationPlatformBridgeTest: chrome/android/junit/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeTest.java chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeTest.java WARNING: multiple definitions of org.chromium.chrome.browser.offlinepages.OfflinePageBridgeTest: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java WARNING: multiple definitions of org.chromium.chrome.browser.offlinepages.OfflinePageUtilsTest: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java BUG=none Committed: https://crrev.com/b1ea0ef113fe546c6b244efad8400d8b21a1ea30 Cr-Commit-Position: refs/heads/master@{#417285}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -950 lines) Patch
M chrome/android/java_sources.gni View 3 chunks +5 lines, -5 lines 0 comments Download
D chrome/android/junit/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java View 1 chunk +0 lines, -224 lines 0 comments Download
A + chrome/android/junit/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableUnitTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/android/junit/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeTest.java View 1 chunk +0 lines, -90 lines 0 comments Download
A + chrome/android/junit/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeUnitTest.java View 1 chunk +1 line, -1 line 0 comments Download
D chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java View 1 chunk +0 lines, -247 lines 0 comments Download
A + chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeUnitTest.java View 1 chunk +1 line, -1 line 0 comments Download
D chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java View 1 chunk +0 lines, -216 lines 0 comments Download
A + chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsUnitTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/android/junit/src/org/chromium/chrome/browser/payments/CurrencyStringFormatterTest.java View 1 chunk +0 lines, -160 lines 0 comments Download
A + chrome/android/junit/src/org/chromium/chrome/browser/payments/CurrencyStringFormatterUnitTest.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
johnme
4 years, 3 months ago (2016-09-08 13:50:09 UTC) #4
Bernhard Bauer
lgtm
4 years, 3 months ago (2016-09-08 13:57:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314423004/1
4 years, 3 months ago (2016-09-08 14:18:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 14:22:34 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 14:25:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1ea0ef113fe546c6b244efad8400d8b21a1ea30
Cr-Commit-Position: refs/heads/master@{#417285}

Powered by Google App Engine
This is Rietveld 408576698