Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4055)

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java

Issue 2314423004: Fix checkdeps warnings due to duplicate JUnit test names (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
deleted file mode 100644
index 5e997d97bb6043ef09ff9e8babe2dc1cb01297c9..0000000000000000000000000000000000000000
--- a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
+++ /dev/null
@@ -1,216 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.chrome.browser.offlinepages;
-
-import static org.junit.Assert.assertEquals;
-import static org.mockito.ArgumentMatchers.any;
-import static org.mockito.ArgumentMatchers.eq;
-import static org.mockito.ArgumentMatchers.isNull;
-import static org.mockito.Mockito.doNothing;
-import static org.mockito.Mockito.doReturn;
-import static org.mockito.Mockito.times;
-import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.when;
-
-import android.os.Environment;
-
-import org.chromium.base.BaseChromiumApplication;
-import org.chromium.base.test.util.Feature;
-import org.chromium.chrome.browser.profiles.Profile;
-import org.chromium.chrome.browser.tab.Tab;
-import org.chromium.components.bookmarks.BookmarkId;
-import org.chromium.components.bookmarks.BookmarkType;
-import org.chromium.content_public.browser.WebContents;
-import org.chromium.testing.local.LocalRobolectricTestRunner;
-import org.junit.Before;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.mockito.Mock;
-import org.mockito.MockitoAnnotations;
-import org.robolectric.annotation.Config;
-import org.robolectric.annotation.Implementation;
-import org.robolectric.annotation.Implements;
-import org.robolectric.shadows.multidex.ShadowMultiDex;
-
-import java.io.File;
-
-/**
- * Unit tests for OfflinePageUtils.
- */
-@RunWith(LocalRobolectricTestRunner.class)
-@Config(manifest = Config.NONE,
- application = BaseChromiumApplication.class,
- shadows = { OfflinePageUtilsTest.WrappedEnvironment.class, ShadowMultiDex.class })
-public class OfflinePageUtilsTest {
-
- @Mock private File mMockDataDirectory;
- @Mock private Tab mTab;
- @Mock private WebContents mWebContents;
- @Mock private OfflinePageBridge mOfflinePageBridge;
- @Mock private OfflinePageUtils mOfflinePageUtils;
-
- @Before
- public void setUp() throws Exception {
- MockitoAnnotations.initMocks(this);
- WrappedEnvironment.setDataDirectoryForTest(mMockDataDirectory);
-
- // Setting up a mock tab. These are the values common to most tests, but individual
- // tests might easily overwrite them.
- doReturn(false).when(mTab).isShowingErrorPage();
- doReturn(false).when(mTab).isShowingSadTab();
- doReturn(mWebContents).when(mTab).getWebContents();
- doReturn(false).when(mWebContents).isDestroyed();
- doReturn(false).when(mWebContents).isIncognito();
-
- doNothing()
- .when(mOfflinePageBridge)
- .savePage(eq(mWebContents), any(ClientId.class),
- any(OfflinePageBridge.SavePageCallback.class));
-
- doReturn(mOfflinePageBridge)
- .when(mOfflinePageUtils)
- .getOfflinePageBridge((Profile) isNull());
- OfflinePageUtils.setInstanceForTesting(mOfflinePageUtils);
-
- OfflinePageBridge.setOfflineBookmarksEnabledForTesting(true);
- }
-
- @Test
- @Feature({"OfflinePages"})
- public void testGetFreeSpaceInBytes() {
- when(mMockDataDirectory.getUsableSpace()).thenReturn(1234L);
- assertEquals(1234L, OfflinePageUtils.getFreeSpaceInBytes());
- }
-
- @Test
- @Feature({"OfflinePages"})
- public void testGetTotalSpaceInBytes() {
- when(mMockDataDirectory.getTotalSpace()).thenReturn(56789L);
- assertEquals(56789L, OfflinePageUtils.getTotalSpaceInBytes());
- }
-
- @Test
- @Feature({"OfflinePages"})
- public void testStripSchemeFromOnlineUrl() {
- // Only scheme gets stripped.
- assertEquals("cs.chromium.org",
- OfflinePageUtils.stripSchemeFromOnlineUrl("https://cs.chromium.org"));
- assertEquals("cs.chromium.org",
- OfflinePageUtils.stripSchemeFromOnlineUrl("http://cs.chromium.org"));
- // If there is no scheme, nothing changes.
- assertEquals("cs.chromium.org",
- OfflinePageUtils.stripSchemeFromOnlineUrl("cs.chromium.org"));
- // Path is not touched/changed.
- String urlWithPath = "code.google.com/p/chromium/codesearch#search"
- + "/&q=offlinepageutils&sq=package:chromium&type=cs";
- assertEquals(urlWithPath,
- OfflinePageUtils.stripSchemeFromOnlineUrl("https://" + urlWithPath));
- // Beginning and ending spaces get trimmed.
- assertEquals("cs.chromium.org",
- OfflinePageUtils.stripSchemeFromOnlineUrl(" https://cs.chromium.org "));
- }
-
- @Test
- @Feature({"OfflinePages"})
- public void testSaveBookmarkOffline() {
- OfflinePageUtils.saveBookmarkOffline(new BookmarkId(42, BookmarkType.NORMAL), mTab);
- verify(mOfflinePageBridge, times(1))
- .savePage(eq(mWebContents), any(ClientId.class),
- any(OfflinePageBridge.SavePageCallback.class));
- }
-
- @Test
- @Feature({"OfflinePages"})
- public void testSaveBookmarkOffline_inputValidation() {
- OfflinePageUtils.saveBookmarkOffline(null, mTab);
- // Save page not called because bookmarkId is null.
- verify(mOfflinePageBridge, times(0))
- .savePage(eq(mWebContents), any(ClientId.class),
- any(OfflinePageBridge.SavePageCallback.class));
-
- BookmarkId bookmarkId = new BookmarkId(42, BookmarkType.NORMAL);
- OfflinePageBridge.setOfflineBookmarksEnabledForTesting(false);
- OfflinePageUtils.saveBookmarkOffline(bookmarkId, mTab);
- // Save page not called because offline bookmarks are disabled.
- verify(mOfflinePageBridge, times(0))
- .savePage(eq(mWebContents), any(ClientId.class),
- any(OfflinePageBridge.SavePageCallback.class));
-
- OfflinePageBridge.setOfflineBookmarksEnabledForTesting(true);
- doReturn(true).when(mTab).isShowingErrorPage();
- OfflinePageUtils.saveBookmarkOffline(bookmarkId, mTab);
- // Save page not called because tab is showing an error page.
- verify(mOfflinePageBridge, times(0))
- .savePage(eq(mWebContents), any(ClientId.class),
- any(OfflinePageBridge.SavePageCallback.class));
-
- doReturn(false).when(mTab).isShowingErrorPage();
- doReturn(true).when(mTab).isShowingSadTab();
- OfflinePageUtils.saveBookmarkOffline(bookmarkId, mTab);
- // Save page not called because tab is showing a sad tab.
- verify(mOfflinePageBridge, times(0))
- .savePage(eq(mWebContents), any(ClientId.class),
- any(OfflinePageBridge.SavePageCallback.class));
-
- doReturn(false).when(mTab).isShowingSadTab();
- doReturn(null).when(mTab).getWebContents();
- OfflinePageUtils.saveBookmarkOffline(bookmarkId, mTab);
- // Save page not called because tab returns null web contents.
- verify(mOfflinePageBridge, times(0))
- .savePage(eq(mWebContents), any(ClientId.class),
- any(OfflinePageBridge.SavePageCallback.class));
-
- doReturn(mWebContents).when(mTab).getWebContents();
- doReturn(true).when(mWebContents).isDestroyed();
- OfflinePageUtils.saveBookmarkOffline(bookmarkId, mTab);
- // Save page not called because web contents is destroyed.
- verify(mOfflinePageBridge, times(0))
- .savePage(eq(mWebContents), any(ClientId.class),
- any(OfflinePageBridge.SavePageCallback.class));
-
- doReturn(false).when(mWebContents).isDestroyed();
- doReturn(true).when(mWebContents).isIncognito();
- OfflinePageUtils.saveBookmarkOffline(bookmarkId, mTab);
- // Save page not called because web contents is incognito.
- verify(mOfflinePageBridge, times(0))
- .savePage(eq(mWebContents), any(ClientId.class),
- any(OfflinePageBridge.SavePageCallback.class));
- }
-
- @Test
- @Feature({"OfflinePagesSharing"})
- public void testRewriteOfflineFileName() {
- // Only dots in file name get replaced.
- assertEquals("cs_chromium_org.mhtml",
- OfflinePageUtils.rewriteOfflineFileName("cs.chromium.org.mhtml"));
- // Successive dots should all be replaced.
- assertEquals("cs_chromium___org_.mhtml",
- OfflinePageUtils.rewriteOfflineFileName("cs.chromium...org..mhtml"));
- // White spaces are trimmed.
- assertEquals("cs_chromium_org.mhtml",
- OfflinePageUtils.rewriteOfflineFileName(" cs.chromium .org .mhtml"));
- // Other special characters is not touched
- String directoryPath = "chrome/src/offline/";
- assertEquals(directoryPath + "cs_chromium!_org#.mhtml",
- OfflinePageUtils.rewriteOfflineFileName(directoryPath + "cs.chromium!.org#.mhtml"));
- // If there is no dot other than file extension, nothing changes.
- assertEquals("chromium.mhtml", OfflinePageUtils.rewriteOfflineFileName("chromium.mhtml"));
- }
-
- /** A shadow/wrapper of android.os.Environment that allows injecting a test directory. */
- @Implements(Environment.class)
- public static class WrappedEnvironment {
- private static File sDataDirectory = null;
-
- public static void setDataDirectoryForTest(File testDirectory) {
- sDataDirectory = testDirectory;
- }
-
- @Implementation
- public static File getDataDirectory() {
- return sDataDirectory;
- }
- }
-}

Powered by Google App Engine
This is Rietveld 408576698