Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java

Issue 2314423004: Fix checkdeps warnings due to duplicate JUnit test names (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
deleted file mode 100644
index 18ada32da440fb4feed0b5ee0f83752d370c7977..0000000000000000000000000000000000000000
--- a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
+++ /dev/null
@@ -1,247 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.chrome.browser.offlinepages;
-
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertTrue;
-import static org.mockito.ArgumentMatchers.anyListOf;
-import static org.mockito.ArgumentMatchers.anyLong;
-import static org.mockito.ArgumentMatchers.anyString;
-import static org.mockito.ArgumentMatchers.eq;
-import static org.mockito.Mockito.doAnswer;
-import static org.mockito.Mockito.doReturn;
-import static org.mockito.Mockito.spy;
-import static org.mockito.Mockito.times;
-import static org.mockito.Mockito.verify;
-
-import org.chromium.base.BaseChromiumApplication;
-import org.chromium.base.Callback;
-import org.chromium.base.ThreadUtils;
-import org.chromium.base.test.util.Feature;
-import org.chromium.chrome.browser.offlinepages.OfflinePageBridge.OfflinePageModelObserver;
-import org.chromium.testing.local.LocalRobolectricTestRunner;
-import org.junit.Before;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.mockito.ArgumentCaptor;
-import org.mockito.Captor;
-import org.mockito.MockitoAnnotations;
-import org.mockito.invocation.InvocationOnMock;
-import org.mockito.stubbing.Answer;
-import org.robolectric.annotation.Config;
-import org.robolectric.shadows.multidex.ShadowMultiDex;
-
-import java.util.List;
-import java.util.Set;
-
-/**
- * Unit tests for OfflinePageUtils.
- */
-@RunWith(LocalRobolectricTestRunner.class)
-@Config(manifest = Config.NONE, application = BaseChromiumApplication.class,
- shadows = {ShadowMultiDex.class})
-public class OfflinePageBridgeTest {
- private OfflinePageBridge mBridge;
-
- private static final String TEST_NAMESPACE = "TEST_NAMESPACE";
- private static final String TEST_ID = "TEST_ID";
- private static final String TEST_URL = "TEST_URL";
- private static final long TEST_OFFLINE_ID = 42;
- private static final ClientId TEST_CLIENT_ID = new ClientId(TEST_NAMESPACE, TEST_ID);
- private static final String TEST_OFFLINE_URL = "TEST_OFFLINE_URL";
- private static final String TEST_FILE_PATH = "TEST_FILE_PATH";
- private static final long TEST_FILESIZE = 12345;
- private static final long TEST_CREATIONTIMEMS = 150;
- private static final int TEST_ACCESSCOUNT = 1;
- private static final long TEST_LASTACCESSTIMEMS = 20160314;
-
- private static final OfflinePageItem TEST_OFFLINE_PAGE_ITEM = new OfflinePageItem(TEST_URL,
- TEST_OFFLINE_ID, TEST_NAMESPACE, TEST_ID, TEST_OFFLINE_URL, TEST_FILE_PATH,
- TEST_FILESIZE, TEST_CREATIONTIMEMS, TEST_ACCESSCOUNT, TEST_LASTACCESSTIMEMS);
-
- @Captor
- ArgumentCaptor<List<OfflinePageItem>> mResultArgument;
-
- @Captor
- ArgumentCaptor<Callback<List<OfflinePageItem>>> mCallbackArgument;
-
- /**
- * Mocks the observer.
- */
- public class MockOfflinePageModelObserver extends OfflinePageModelObserver {
- public long lastDeletedOfflineId;
- public ClientId lastDeletedClientId;
-
- public void offlinePageDeleted(long offlineId, ClientId clientId) {
- lastDeletedOfflineId = offlineId;
- lastDeletedClientId = clientId;
- }
- }
-
- @Before
- public void setUp() throws Exception {
- MockitoAnnotations.initMocks(this);
- OfflinePageBridge bridge = new OfflinePageBridge(0);
- // Using the spy to automatically marshal all the calls to the original methods if they are
- // not mocked explicitly.
- mBridge = spy(bridge);
- }
-
- /**
- * Tests OfflinePageBridge#getPageByClientId() method in a scenario where a model was loaded.
- */
- @Test
- @Feature({"OfflinePages"})
- public void testGetPageByClientId() {
- doReturn(new long[] {123, 456})
- .when(mBridge)
- .nativeGetOfflineIdsForClientId(anyLong(), eq(TEST_NAMESPACE), eq(TEST_ID));
-
- mBridge.offlinePageModelLoaded();
-
- ClientId testClientId = new ClientId(TEST_NAMESPACE, TEST_ID);
- Set<Long> result = mBridge.getOfflineIdsForClientId(testClientId);
- assertEquals(2, result.size());
- assertTrue(result.contains(123L));
- assertTrue(result.contains(456L));
- verify(mBridge, times(1))
- .nativeGetOfflineIdsForClientId(anyLong(), anyString(), anyString());
- }
-
- /**
- * Tests getClientIdForOfflineId.
- */
- @Test
- @Feature({"OfflinePages"})
- public void testGetClientIdForOfflineId() {
- doReturn(TEST_OFFLINE_PAGE_ITEM)
- .when(mBridge)
- .nativeGetPageByOfflineId(anyLong(), eq(TEST_OFFLINE_ID));
-
- mBridge.offlinePageModelLoaded();
- long testOfflineId = TEST_OFFLINE_ID;
- ClientId resultClientId = mBridge.getClientIdForOfflineId(testOfflineId);
- assertEquals(resultClientId, TEST_CLIENT_ID);
- verify(mBridge, times(1)).getClientIdForOfflineId(eq(TEST_OFFLINE_ID));
- verify(mBridge, times(1)).nativeGetPageByOfflineId(anyLong(), eq(TEST_OFFLINE_ID));
- }
-
- /**
- * Tests getClientIdForOfflineId for null.
- */
- @Test
- @Feature({"OfflinePages"})
- public void testGetClientIdForOfflineIdNull() {
- doReturn(null).when(mBridge).nativeGetPageByOfflineId(anyLong(), eq(TEST_OFFLINE_ID));
- mBridge.offlinePageModelLoaded();
- long testOfflineId = TEST_OFFLINE_ID;
- ClientId resultClientId = mBridge.getClientIdForOfflineId(testOfflineId);
- assertEquals(resultClientId, null);
- verify(mBridge, times(1)).getClientIdForOfflineId(eq(TEST_OFFLINE_ID));
- verify(mBridge, times(1)).nativeGetPageByOfflineId(anyLong(), eq(TEST_OFFLINE_ID));
- }
-
- @Test(expected = AssertionError.class)
- @Feature({"OfflinePages"})
- public void testGetPageByClientId_ModelNotLoaded() {
- ClientId testClientId = new ClientId("TEST_NAMESPACE", "TEST_ID");
- Set<Long> result = mBridge.getOfflineIdsForClientId(testClientId);
- }
-
- /**
- * Tests OfflinePageBridge#OfflinePageDeleted() callback with two observers attached.
- */
- @Test
- @Feature({"OfflinePages"})
- public void testRemovePageByClientId() {
- MockOfflinePageModelObserver observer1 = new MockOfflinePageModelObserver();
- MockOfflinePageModelObserver observer2 = new MockOfflinePageModelObserver();
- mBridge.addObserver(observer1);
- mBridge.addObserver(observer2);
-
- ClientId testClientId = new ClientId(TEST_NAMESPACE, TEST_ID);
- long testOfflineId = 123;
- mBridge.offlinePageDeleted(testOfflineId, testClientId);
- assertEquals(testOfflineId, observer1.lastDeletedOfflineId);
- assertEquals(testClientId, observer1.lastDeletedClientId);
- assertEquals(testOfflineId, observer2.lastDeletedOfflineId);
- assertEquals(testClientId, observer2.lastDeletedClientId);
- }
-
- /**
- * Tests OfflinePageBridge#GetAllPages() callback when there are no pages.
- */
- @Test
- @Feature({"OfflinePages"})
- public void testGetAllPages_listOfPagesEmpty() {
- final int itemCount = 0;
-
- answerNativeGetAllPages(itemCount);
- Callback<List<OfflinePageItem>> callback = createMultipleItemCallback(itemCount);
-
- mBridge.getAllPages(callback);
- verify(callback, times(1)).onResult(anyListOf(OfflinePageItem.class));
- }
-
- /**
- * Tests OfflinePageBridge#GetAllPages() callback when there are pages.
- */
- @Test
- @Feature({"OfflinePages"})
- public void testGetAllPages_listOfPagesNonEmpty() {
- final int itemCount = 2;
-
- answerNativeGetAllPages(itemCount);
- Callback<List<OfflinePageItem>> callback = createMultipleItemCallback(itemCount);
-
- mBridge.getAllPages(callback);
- verify(callback, times(1)).onResult(anyListOf(OfflinePageItem.class));
- }
-
- /** Performs a proper cast from Object to a List<OfflinePageItem>. */
- private static List<OfflinePageItem> convertToListOfOfflinePages(Object o) {
- @SuppressWarnings("unchecked")
- List<OfflinePageItem> list = (List<OfflinePageItem>) o;
- return list;
- }
-
- private void postOfflinePageModelLoadedEvent() {
- ThreadUtils.postOnUiThread(new Runnable() {
- @Override
- public void run() {
- mBridge.offlinePageModelLoaded();
- }
- });
- }
-
- private Callback<List<OfflinePageItem>> createMultipleItemCallback(final int itemCount) {
- return spy(new Callback<List<OfflinePageItem>>() {
- @Override
- public void onResult(List<OfflinePageItem> items) {
- assertNotNull(items);
- assertEquals(itemCount, items.size());
- }
- });
- }
-
- private void answerNativeGetAllPages(final int itemCount) {
- Answer<Void> answer = new Answer<Void>() {
- @Override
- public Void answer(InvocationOnMock invocation) {
- List<OfflinePageItem> result = mResultArgument.getValue();
- for (int i = 0; i < itemCount; i++) {
- result.add(TEST_OFFLINE_PAGE_ITEM);
- }
-
- mCallbackArgument.getValue().onResult(result);
-
- return null;
- }
- };
- doAnswer(answer).when(mBridge).nativeGetAllPages(
- anyLong(), mResultArgument.capture(), mCallbackArgument.capture());
- }
-}

Powered by Google App Engine
This is Rietveld 408576698