Reland of land Compile under-invalidation checking in all builds

Reland of land Compile under-invalidation checking in all builds (patchset #2 id:300001 of https://codereview.chromium.org/2309193002/ )

Reason for revert:
This should be landed to discover under-invalidations. If any test hit this, we should mark the test fail instead of reverting this.

The failed test had been marked failure before the revert.

Original issue's description:
> Revert of Reland Compile under-invalidation checking in all builds (patchset #4 id:60001 of https://codereview.chromium.org/2301303002/ )
>
> Reason for revert:
> Causing failures on WebKit Mac 10.9:
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9
>
> updating-scrolling-container-and-content.html is hitting the new CHECK on
> PaintController.cpp:662. It's not clear why this passed on build #36527; all
> other builds since this landed failed.
>
> Original issue's description:
> > Reland Compile under-invalidation checking in all builds
> >
> > This relands https://codereview.chromium.org/2299223002 which was
> > reverted because of random pixel under-invalidations.
> >
> > Now clear the bitmaps before drawing the pictures.
> >
> > BTW changed the error indication color from solid red to translucent
> > magenta to distinguish from the normal red pixels in test results.
> >
> > > This will let the tests having under-invalidation issues produce the
> > > same result on all builds, so enable us to rebaseline the tests with
> > > failure results. In this way we can track either regressions and
> > > progressions instead of ignoring the tests.
> > >
> > > BUG=619103
> > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > >
> > > Review-Url: https://codereview.chromium.org/2299223002
> > > Cr-Commit-Position: refs/heads/master@{#416060}
> >
> > BUG=619103
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > R=pdr@chromium.org
>
> TBR=pdr@chromium.org,wangxianzhu@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=619103
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807
> Cr-Commit-Position: refs/heads/master@{#416516}

TBR=pdr@chromium.org,mgiuca@chromium.org
BUG=619103, 644358
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33
Cr-Commit-Position: refs/heads/master@{#416800}

[Xianzhu, 2016-09-06 16:09:12]

Created Reland of land Compile under-invalidation checking in all builds

[Xianzhu, 2016-09-06 16:27:43]

On 2016/09/06 16:09:12, Xianzhu wrote:
> Created Reland of land Compile under-invalidation checking in all builds

Actually I already marked the failed test as failure 1 day before the revert:
https://codereview.chromium.org/2308743002/.

[Xianzhu, 2016-09-06 16:28:11]

Description was changed from

==========
Reland of land Compile under-invalidation checking in all builds (patchset #2
id:300001 of https://codereview.chromium.org/2309193002/ )

Reason for revert:
This should be landed to discover under-invalidations. If any test hit this, we
should mark the test fail instead of reverting this.


Original issue's description:
> Revert of Reland Compile under-invalidation checking in all builds (patchset
#4 id:60001 of https://codereview.chromium.org/2301303002/ )
> 
> Reason for revert:
> Causing failures on WebKit Mac 10.9:
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9
> 
> updating-scrolling-container-and-content.html is hitting the new CHECK on
> PaintController.cpp:662. It's not clear why this passed on build #36527; all
> other builds since this landed failed.
> 
> Original issue's description:
> > Reland Compile under-invalidation checking in all builds
> >
> > This relands https://codereview.chromium.org/2299223002 which was
> > reverted because of random pixel under-invalidations.
> >
> > Now clear the bitmaps before drawing the pictures.
> >
> > BTW changed the error indication color from solid red to translucent
> > magenta to distinguish from the normal red pixels in test results.
> >
> > > This will let the tests having under-invalidation issues produce the
> > > same result on all builds, so enable us to rebaseline the tests with
> > > failure results. In this way we can track either regressions and
> > > progressions instead of ignoring the tests.
> > >
> > > BUG=619103
> > >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > >
> > > Review-Url: https://codereview.chromium.org/2299223002
> > > Cr-Commit-Position: refs/heads/master@{#416060}
> >
> > BUG=619103
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > R=pdr@chromium.org
> 
> TBR=pdr@chromium.org,wangxianzhu@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=619103
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Committed: https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807
> Cr-Commit-Position: refs/heads/master@{#416516}

TBR=pdr@chromium.org,mgiuca@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=619103
==========

to

==========
Reland of land Compile under-invalidation checking in all builds (patchset #2
id:300001 of https://codereview.chromium.org/2309193002/ )

Reason for revert:
This should be landed to discover under-invalidations. If any test hit this, we
should mark the test fail instead of reverting this.

The failed test had been marked failure before the revert.


Original issue's description:
> Revert of Reland Compile under-invalidation checking in all builds (patchset
#4 id:60001 of https://codereview.chromium.org/2301303002/ )
> 
> Reason for revert:
> Causing failures on WebKit Mac 10.9:
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9
> 
> updating-scrolling-container-and-content.html is hitting the new CHECK on
> PaintController.cpp:662. It's not clear why this passed on build #36527; all
> other builds since this landed failed.
> 
> Original issue's description:
> > Reland Compile under-invalidation checking in all builds
> >
> > This relands https://codereview.chromium.org/2299223002 which was
> > reverted because of random pixel under-invalidations.
> >
> > Now clear the bitmaps before drawing the pictures.
> >
> > BTW changed the error indication color from solid red to translucent
> > magenta to distinguish from the normal red pixels in test results.
> >
> > > This will let the tests having under-invalidation issues produce the
> > > same result on all builds, so enable us to rebaseline the tests with
> > > failure results. In this way we can track either regressions and
> > > progressions instead of ignoring the tests.
> > >
> > > BUG=619103
> > >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > >
> > > Review-Url: https://codereview.chromium.org/2299223002
> > > Cr-Commit-Position: refs/heads/master@{#416060}
> >
> > BUG=619103
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > R=pdr@chromium.org
> 
> TBR=pdr@chromium.org,wangxianzhu@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=619103
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Committed: https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807
> Cr-Commit-Position: refs/heads/master@{#416516}

TBR=pdr@chromium.org,mgiuca@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=619103
==========

[Xianzhu, 2016-09-06 16:28:18]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-09-06 16:28:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2016-09-06 16:31:38]

On 2016/09/06 at 16:28:41, commit-bot wrote:
> CQ is trying da patch. Follow status at
>  
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

LGTM

[Xianzhu, 2016-09-06 16:39:20]

Description was changed from

==========
Reland of land Compile under-invalidation checking in all builds (patchset #2
id:300001 of https://codereview.chromium.org/2309193002/ )

Reason for revert:
This should be landed to discover under-invalidations. If any test hit this, we
should mark the test fail instead of reverting this.

The failed test had been marked failure before the revert.


Original issue's description:
> Revert of Reland Compile under-invalidation checking in all builds (patchset
#4 id:60001 of https://codereview.chromium.org/2301303002/ )
> 
> Reason for revert:
> Causing failures on WebKit Mac 10.9:
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9
> 
> updating-scrolling-container-and-content.html is hitting the new CHECK on
> PaintController.cpp:662. It's not clear why this passed on build #36527; all
> other builds since this landed failed.
> 
> Original issue's description:
> > Reland Compile under-invalidation checking in all builds
> >
> > This relands https://codereview.chromium.org/2299223002 which was
> > reverted because of random pixel under-invalidations.
> >
> > Now clear the bitmaps before drawing the pictures.
> >
> > BTW changed the error indication color from solid red to translucent
> > magenta to distinguish from the normal red pixels in test results.
> >
> > > This will let the tests having under-invalidation issues produce the
> > > same result on all builds, so enable us to rebaseline the tests with
> > > failure results. In this way we can track either regressions and
> > > progressions instead of ignoring the tests.
> > >
> > > BUG=619103
> > >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > >
> > > Review-Url: https://codereview.chromium.org/2299223002
> > > Cr-Commit-Position: refs/heads/master@{#416060}
> >
> > BUG=619103
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > R=pdr@chromium.org
> 
> TBR=pdr@chromium.org,wangxianzhu@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=619103
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Committed: https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807
> Cr-Commit-Position: refs/heads/master@{#416516}

TBR=pdr@chromium.org,mgiuca@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=619103
==========

to

==========
Reland of land Compile under-invalidation checking in all builds (patchset #2
id:300001 of https://codereview.chromium.org/2309193002/ )

Reason for revert:
This should be landed to discover under-invalidations. If any test hit this, we
should mark the test fail instead of reverting this.

The failed test had been marked failure before the revert.


Original issue's description:
> Revert of Reland Compile under-invalidation checking in all builds (patchset
#4 id:60001 of https://codereview.chromium.org/2301303002/ )
> 
> Reason for revert:
> Causing failures on WebKit Mac 10.9:
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9
> 
> updating-scrolling-container-and-content.html is hitting the new CHECK on
> PaintController.cpp:662. It's not clear why this passed on build #36527; all
> other builds since this landed failed.
> 
> Original issue's description:
> > Reland Compile under-invalidation checking in all builds
> >
> > This relands https://codereview.chromium.org/2299223002 which was
> > reverted because of random pixel under-invalidations.
> >
> > Now clear the bitmaps before drawing the pictures.
> >
> > BTW changed the error indication color from solid red to translucent
> > magenta to distinguish from the normal red pixels in test results.
> >
> > > This will let the tests having under-invalidation issues produce the
> > > same result on all builds, so enable us to rebaseline the tests with
> > > failure results. In this way we can track either regressions and
> > > progressions instead of ignoring the tests.
> > >
> > > BUG=619103
> > >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > >
> > > Review-Url: https://codereview.chromium.org/2299223002
> > > Cr-Commit-Position: refs/heads/master@{#416060}
> >
> > BUG=619103
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > R=pdr@chromium.org
> 
> TBR=pdr@chromium.org,wangxianzhu@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=619103
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Committed: https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807
> Cr-Commit-Position: refs/heads/master@{#416516}

TBR=pdr@chromium.org,mgiuca@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=619103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-09-06 16:39:22]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-09-06 16:39:22]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2314103002/#ps300001
(title: "Crash Timeout")

[commit-bot: I haz the power, 2016-09-06 16:39:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-09-06 16:40:10]

It seems that crashing tests flakily timeout on Mac 10.9. Added Timeout
expectation to the test. Will file a bug.

[pdr., 2016-09-06 17:46:10]

On 2016/09/06 at 16:40:10, wangxianzhu wrote:
> It seems that crashing tests flakily timeout on Mac 10.9. Added Timeout
expectation to the test. Will file a bug.

The spv2 trybot failure may be real as well.

[commit-bot: I haz the power, 2016-09-06 17:56:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 17:56:06]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[Xianzhu, 2016-09-06 18:01:20]

Description was changed from

==========
Reland of land Compile under-invalidation checking in all builds (patchset #2
id:300001 of https://codereview.chromium.org/2309193002/ )

Reason for revert:
This should be landed to discover under-invalidations. If any test hit this, we
should mark the test fail instead of reverting this.

The failed test had been marked failure before the revert.


Original issue's description:
> Revert of Reland Compile under-invalidation checking in all builds (patchset
#4 id:60001 of https://codereview.chromium.org/2301303002/ )
> 
> Reason for revert:
> Causing failures on WebKit Mac 10.9:
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9
> 
> updating-scrolling-container-and-content.html is hitting the new CHECK on
> PaintController.cpp:662. It's not clear why this passed on build #36527; all
> other builds since this landed failed.
> 
> Original issue's description:
> > Reland Compile under-invalidation checking in all builds
> >
> > This relands https://codereview.chromium.org/2299223002 which was
> > reverted because of random pixel under-invalidations.
> >
> > Now clear the bitmaps before drawing the pictures.
> >
> > BTW changed the error indication color from solid red to translucent
> > magenta to distinguish from the normal red pixels in test results.
> >
> > > This will let the tests having under-invalidation issues produce the
> > > same result on all builds, so enable us to rebaseline the tests with
> > > failure results. In this way we can track either regressions and
> > > progressions instead of ignoring the tests.
> > >
> > > BUG=619103
> > >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > >
> > > Review-Url: https://codereview.chromium.org/2299223002
> > > Cr-Commit-Position: refs/heads/master@{#416060}
> >
> > BUG=619103
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > R=pdr@chromium.org
> 
> TBR=pdr@chromium.org,wangxianzhu@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=619103
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Committed: https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807
> Cr-Commit-Position: refs/heads/master@{#416516}

TBR=pdr@chromium.org,mgiuca@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=619103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Reland of land Compile under-invalidation checking in all builds (patchset #2
id:300001 of https://codereview.chromium.org/2309193002/ )

Reason for revert:
This should be landed to discover under-invalidations. If any test hit this, we
should mark the test fail instead of reverting this.

The failed test had been marked failure before the revert.


Original issue's description:
> Revert of Reland Compile under-invalidation checking in all builds (patchset
#4 id:60001 of https://codereview.chromium.org/2301303002/ )
>
> Reason for revert:
> Causing failures on WebKit Mac 10.9:
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9
>
> updating-scrolling-container-and-content.html is hitting the new CHECK on
> PaintController.cpp:662. It's not clear why this passed on build #36527; all
> other builds since this landed failed.
>
> Original issue's description:
> > Reland Compile under-invalidation checking in all builds
> >
> > This relands https://codereview.chromium.org/2299223002 which was
> > reverted because of random pixel under-invalidations.
> >
> > Now clear the bitmaps before drawing the pictures.
> >
> > BTW changed the error indication color from solid red to translucent
> > magenta to distinguish from the normal red pixels in test results.
> >
> > > This will let the tests having under-invalidation issues produce the
> > > same result on all builds, so enable us to rebaseline the tests with
> > > failure results. In this way we can track either regressions and
> > > progressions instead of ignoring the tests.
> > >
> > > BUG=619103
> > >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > >
> > > Review-Url: https://codereview.chromium.org/2299223002
> > > Cr-Commit-Position: refs/heads/master@{#416060}
> >
> > BUG=619103
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > R=pdr@chromium.org
>
> TBR=pdr@chromium.org,wangxianzhu@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=619103
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807
> Cr-Commit-Position: refs/heads/master@{#416516}

TBR=pdr@chromium.org,mgiuca@chromium.org
BUG=619103,644358
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-09-06 18:02:08]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-09-06 18:02:08]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2314103002/#ps320001
(title: "SPv2 under-invalidations (crbug.com/644358)")

[commit-bot: I haz the power, 2016-09-06 18:03:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2016-09-06 20:26:19]

On 2016/09/06 at 18:03:05, commit-bot wrote:
> CQ is trying da patch. Follow status at
>  
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

I think the fast/forms/relayout-shifts-inner-editor.html failure is real too and
just needs to be added to the enable-slimming-paint-v2 list.

[Xianzhu, 2016-09-06 20:29:16]

On 2016/09/06 20:26:19, pdr. wrote:
> On 2016/09/06 at 18:03:05, commit-bot wrote:
> > CQ is trying da patch. Follow status at
> >  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> 
> I think the fast/forms/relayout-shifts-inner-editor.html failure is real too
and
> just needs to be added to the enable-slimming-paint-v2 list.

It's weird that I already added it in enable-slimming-paint-v2 but the bot still
reported it as an unexpected crash.

[pdr., 2016-09-06 20:30:28]

On 2016/09/06 at 20:29:16, wangxianzhu wrote:
> On 2016/09/06 20:26:19, pdr. wrote:
> > On 2016/09/06 at 18:03:05, commit-bot wrote:
> > > CQ is trying da patch. Follow status at
> > >  
> >
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> > 
> > I think the fast/forms/relayout-shifts-inner-editor.html failure is real too
and
> > just needs to be added to the enable-slimming-paint-v2 list.
> 
> It's weird that I already added it in enable-slimming-paint-v2 but the bot
still reported it as an unexpected crash.

Oops, I missed that.

It's because there is now a duplicate entry for
relayout-shifts-inner-editor.html in the expectation file.

[Xianzhu, 2016-09-06 20:33:39]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-09-06 20:33:39]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2314103002/#ps340001
(title: "fast/forms/relayout-shifts-inner-editor.html")

[commit-bot: I haz the power, 2016-09-06 20:34:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2016-09-06 22:22:14]

On 2016/09/06 at 20:34:25, commit-bot wrote:
> CQ is trying da patch. Follow status at
>  
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

The new failures are due to https://codereview.chromium.org/2313723006 which
removed 4 lines from test expectations that were passing but are now failing.
Please add them back. Sorry this patch is becoming just a pain :( :( :(

[Xianzhu, 2016-09-06 22:28:05]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-09-06 22:28:05]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2314103002/#ps360001
(title: "More expectations")

[commit-bot: I haz the power, 2016-09-06 22:28:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Matt Giuca, 2016-09-06 23:56:30]

On 2016/09/06 22:28:22, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

I don't have any real context on this (I was sheriffing) but I think if you are
landing code that is making tests fail, you should fix the tests before landing
the code, not disable them and reland.

[Xianzhu, 2016-09-07 00:19:46]

On 2016/09/06 23:56:30, Matt Giuca wrote:
> On 2016/09/06 22:28:22, commit-bot: I haz the power wrote:
> > CQ is trying da patch. Follow status at
> >  
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> 
> I don't have any real context on this (I was sheriffing) but I think if you
are
> landing code that is making tests fail, you should fix the tests before
landing
> the code, not disable them and reland.

The added code is for testing, to expose the existing issues of the tests.

[commit-bot: I haz the power, 2016-09-07 00:41:53]

Committed patchset #5 (id:360001)

[commit-bot: I haz the power, 2016-09-07 00:43:22]

Description was changed from

==========
Reland of land Compile under-invalidation checking in all builds (patchset #2
id:300001 of https://codereview.chromium.org/2309193002/ )

Reason for revert:
This should be landed to discover under-invalidations. If any test hit this, we
should mark the test fail instead of reverting this.

The failed test had been marked failure before the revert.


Original issue's description:
> Revert of Reland Compile under-invalidation checking in all builds (patchset
#4 id:60001 of https://codereview.chromium.org/2301303002/ )
>
> Reason for revert:
> Causing failures on WebKit Mac 10.9:
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9
>
> updating-scrolling-container-and-content.html is hitting the new CHECK on
> PaintController.cpp:662. It's not clear why this passed on build #36527; all
> other builds since this landed failed.
>
> Original issue's description:
> > Reland Compile under-invalidation checking in all builds
> >
> > This relands https://codereview.chromium.org/2299223002 which was
> > reverted because of random pixel under-invalidations.
> >
> > Now clear the bitmaps before drawing the pictures.
> >
> > BTW changed the error indication color from solid red to translucent
> > magenta to distinguish from the normal red pixels in test results.
> >
> > > This will let the tests having under-invalidation issues produce the
> > > same result on all builds, so enable us to rebaseline the tests with
> > > failure results. In this way we can track either regressions and
> > > progressions instead of ignoring the tests.
> > >
> > > BUG=619103
> > >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > >
> > > Review-Url: https://codereview.chromium.org/2299223002
> > > Cr-Commit-Position: refs/heads/master@{#416060}
> >
> > BUG=619103
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > R=pdr@chromium.org
>
> TBR=pdr@chromium.org,wangxianzhu@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=619103
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807
> Cr-Commit-Position: refs/heads/master@{#416516}

TBR=pdr@chromium.org,mgiuca@chromium.org
BUG=619103,644358
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Reland of land Compile under-invalidation checking in all builds (patchset #2
id:300001 of https://codereview.chromium.org/2309193002/ )

Reason for revert:
This should be landed to discover under-invalidations. If any test hit this, we
should mark the test fail instead of reverting this.

The failed test had been marked failure before the revert.

Original issue's description:
> Revert of Reland Compile under-invalidation checking in all builds (patchset
#4 id:60001 of https://codereview.chromium.org/2301303002/ )
>
> Reason for revert:
> Causing failures on WebKit Mac 10.9:
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9
>
> updating-scrolling-container-and-content.html is hitting the new CHECK on
> PaintController.cpp:662. It's not clear why this passed on build #36527; all
> other builds since this landed failed.
>
> Original issue's description:
> > Reland Compile under-invalidation checking in all builds
> >
> > This relands https://codereview.chromium.org/2299223002 which was
> > reverted because of random pixel under-invalidations.
> >
> > Now clear the bitmaps before drawing the pictures.
> >
> > BTW changed the error indication color from solid red to translucent
> > magenta to distinguish from the normal red pixels in test results.
> >
> > > This will let the tests having under-invalidation issues produce the
> > > same result on all builds, so enable us to rebaseline the tests with
> > > failure results. In this way we can track either regressions and
> > > progressions instead of ignoring the tests.
> > >
> > > BUG=619103
> > >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > >
> > > Review-Url: https://codereview.chromium.org/2299223002
> > > Cr-Commit-Position: refs/heads/master@{#416060}
> >
> > BUG=619103
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > R=pdr@chromium.org
>
> TBR=pdr@chromium.org,wangxianzhu@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=619103
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807
> Cr-Commit-Position: refs/heads/master@{#416516}

TBR=pdr@chromium.org,mgiuca@chromium.org
BUG=619103,644358
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33
Cr-Commit-Position: refs/heads/master@{#416800}
==========

[commit-bot: I haz the power, 2016-09-07 00:43:24]

Patchset 5 (id:??) landed as
https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33
Cr-Commit-Position: refs/heads/master@{#416800}

[Matt Giuca, 2016-09-07 01:09:07]

mgiuca@chromium.org changed reviewers:
- mgiuca@chromium.org

[Matt Giuca, 2016-09-07 01:09:08]

Do you at least have a plan to fix those tests?

This should not be how it works, you can't just add a CL that breaks some
previously-passing tests (even if the tests were bad) and disable the tests.
Unless you plan to fix them, they will likely just languish as failing forever.

[Xianzhu, 2016-09-07 01:10:16]

On 2016/09/07 01:09:08, Matt Giuca wrote:
> Do you at least have a plan to fix those tests?
>

Definitely, otherwise we won't add the Failure entries.
 
> This should not be how it works, you can't just add a CL that breaks some
> previously-passing tests (even if the tests were bad) and disable the tests.
> Unless you plan to fix them, they will likely just languish as failing
forever.

[pdr., 2016-09-07 04:34:31]

On 2016/09/07 at 01:09:08, mgiuca wrote:
> Do you at least have a plan to fix those tests?
> 
> This should not be how it works, you can't just add a CL that breaks some
previously-passing tests (even if the tests were bad) and disable the tests.
Unless you plan to fix them, they will likely just languish as failing forever.

Sorry about the sheriff duty confusion. A longer description might have made
this easier on your sheriff duty; we didn't expect to see this many release-mode
failures that were not caught on dcheck-enabled bots :/

For a little more context: this change isn't adding any features, just a new
kind of assert (only enabled via a flag) that is exposing existing bugs we
didn't know about. By landing with tests suppressed, the new underinvalidation
asserts can be used to prove the resulting fixes work. The linked bug (619103)
shows a history of when Xianzhu added this assert for dcheck builds and then
quickly knocked off the bugs.