Added of new UMA signals in order to be able to discover early if the "save password" feature gets …

chrome/browser/password_manager/password_manager_metrics_util_unittest.cc

Index: chrome/browser/password_manager/password_manager_metrics_util_unittest.cc
diff --git a/chrome/browser/password_manager/password_manager_metrics_util_unittest.cc b/chrome/browser/password_manager/password_manager_metrics_util_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..aa3e3a63579f538b0fd453e19992bf142c77556a
--- /dev/null
+++ b/chrome/browser/password_manager/password_manager_metrics_util_unittest.cc
@@ -0,0 +1,27 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/password_manager/password_manager_metrics_util.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+TEST(PasswordManagerTest, IsDomainNameMonitoredTest) {
+  std::string domain_name;
+
+  domain_name = password_manager_metrics_util::IsDomainNameMonitored(
+      "https://www.linkedin.com");
+  EXPECT_FALSE(domain_name.empty());
+  domain_name = password_manager_metrics_util::IsDomainNameMonitored(
+      "https://www.amazon.com");
+  EXPECT_FALSE(domain_name.empty());
+  domain_name = password_manager_metrics_util::IsDomainNameMonitored(
+      "https://www.facebook.com");
+  EXPECT_EQ("", domain_name);

[vabr (Chromium), 2013/09/10 08:46:53]

nit:
EXPECT_TRUE(domain_name.empty())

that would probably be more efficient, and consistent with the EXPECT_FALSE
statements here.

(also below)

[jdomingos, 2013/09/10 16:49:13]

Done.

+  domain_name = password_manager_metrics_util::IsDomainNameMonitored(
+      "http://wikipedia.org");
+  EXPECT_FALSE(domain_name.empty());
+  domain_name = password_manager_metrics_util::IsDomainNameMonitored(
+      "http://thisisnotwikipedia.org");
+  EXPECT_EQ("", domain_name);
+}