chrome/browser/password_manager/password_manager_metrics_util_unittest.cc - Issue 23140005: Added of new UMA signals in order to be able to discover early if the "save password" feature gets …

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/password_manager/password_manager_metrics_util_unittest.cc

Issue 23140005: Added of new UMA signals in order to be able to discover early if the "save password" feature gets … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor changes Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/password_manager/password_manager_metrics_util.cc ('K') | « chrome/browser/password_manager/password_manager_metrics_util.cc ('k') | chrome/browser/password_manager/password_manager_unittest.cc » ('j') | chrome/chrome_browser.gypi » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/password_manager/password_manager_metrics_util.h"

	6

	7 #include "testing/gtest/include/gtest/gtest.h"

	8

	9 TEST(PasswordManagerTest, IsDomainNameMonitoredTest) {

	10 std::string domain_name;

	11

	12 domain_name = password_manager_metrics_util::IsDomainNameMonitored(

	13 "https://www.linkedin.com");

	14 EXPECT_FALSE(domain_name.empty());

	15 domain_name = password_manager_metrics_util::IsDomainNameMonitored(

	16 "https://www.amazon.com");

	17 EXPECT_FALSE(domain_name.empty());

	18 domain_name = password_manager_metrics_util::IsDomainNameMonitored(

	19 "https://www.facebook.com");

	20 EXPECT_EQ("", domain_name);
	vabr (Chromium) 2013/09/10 08:46:53 nit: EXPECT_TRUE(domain_name.empty()) that would nit: EXPECT_TRUE(domain_name.empty()) that would probably be more efficient, and consistent with the EXPECT_FALSE statements here. (also below) jdomingos 2013/09/10 16:49:13 Done. Show quoted text On 2013/09/10 08:46:53, vabr (Chromium) wrote: > nit: > EXPECT_TRUE(domain_name.empty()) > > that would probably be more efficient, and consistent with the EXPECT_FALSE > statements here. > > (also below) Done.
	21 domain_name = password_manager_metrics_util::IsDomainNameMonitored(

	22 "http://wikipedia.org");

	23 EXPECT_FALSE(domain_name.empty());

	24 domain_name = password_manager_metrics_util::IsDomainNameMonitored(

	25 "http://thisisnotwikipedia.org");

	26 EXPECT_EQ("", domain_name);

	27 }

OLD	NEW