chrome/chrome_browser.gypi - Issue 23140005: Added of new UMA signals in order to be able to discover early if the "save password" feature gets …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 23140005: Added of new UMA signals in order to be able to discover early if the "save password" feature gets … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor changes Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_manager_metrics_util_unittest.cc ('K') | « chrome/browser/password_manager/password_manager_unittest.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 338d59b007ba93feece0ecf99a0a976d461e5d33..a55aa22668b790523f956c77f1104f6618ebe434 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -1297,10 +1297,12 @@

'browser/password_manager/password_generation_manager.cc',

'browser/password_manager/password_generation_manager.h',

'browser/password_manager/password_manager.cc',

- 'browser/password_manager/password_manager.h',

+ 'browser/password_manager/password_manager.h',

vabr (Chromium) 2013/09/10 08:46:53 Please remove the added whitespace.

jdomingos 2013/09/10 16:49:13 Done.

'browser/password_manager/password_manager_delegate.h',

'browser/password_manager/password_manager_delegate_impl.cc',

'browser/password_manager/password_manager_delegate_impl.h',

+ 'browser/password_manager/password_manager_metrics_util.cc',

+ 'browser/password_manager/password_manager_metrics_util.h',

'browser/password_manager/password_store.cc',

'browser/password_manager/password_store.h',

'browser/password_manager/password_store_consumer.cc',