Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2313803003: [turbofan] ARM: Implement vswp and use in gap resolver (Closed)

Created:
4 years, 3 months ago by martyn.capewell
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] ARM: Implement vswp and use in gap resolver Use vswp to switch double-precision registers in the gap resolver, with fall back temp register-based code if NEON is not available. BUG= Committed: https://crrev.com/2837c2e65a2ee5b9fc610f30ce1215f52323ecbd Cr-Commit-Position: refs/heads/master@{#39209}

Patch Set 1 #

Patch Set 2 : Fix git's broken rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -22 lines) Patch
M src/arm/assembler-arm.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M src/arm/assembler-arm.cc View 1 1 chunk +21 lines, -0 lines 0 comments Download
M src/arm/disasm-arm.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 1 chunk +19 lines, -21 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 1 chunk +49 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
martyn.capewell
4 years, 3 months ago (2016-09-06 10:49:17 UTC) #3
Benedikt Meurer
Nice, LGTM.
4 years, 3 months ago (2016-09-06 10:57:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313803003/1
4 years, 3 months ago (2016-09-06 12:18:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/8028) v8_linux_arm_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 3 months ago (2016-09-06 12:49:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313803003/20001
4 years, 3 months ago (2016-09-06 13:28:57 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-06 14:07:06 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2837c2e65a2ee5b9fc610f30ce1215f52323ecbd Cr-Commit-Position: refs/heads/master@{#39209}
4 years, 3 months ago (2016-09-06 14:07:17 UTC) #15
Michael Achenbach
4 years, 3 months ago (2016-09-06 14:22:25 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2314003003/ by machenbach@chromium.org.

The reason for reverting is: Breaks arm compilation:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20builder/....

Powered by Google App Engine
This is Rietveld 408576698