Issue 2313723008: Make ios/try recipe expectations more accurate

Issue 2313723008: Make ios/try recipe expectations more accurate (Closed)

Created:
4 years, 3 months ago by iannucci

Modified:
4 years, 3 months ago

Reviewers:
smut, smut

CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org

Target Ref:
refs/heads/master

Project:
build

Visibility:
Public.

Make ios/try recipe expectations more accurate Removes patch_url (which fetches a patch from an SVN server) in favor of the parameters (issue, patchset, rietveld) which this recipe actually takes in production. R=smut@chromium.org BUG=643885 Committed: https://chromium.googlesource.com/chromium/tools/build/+/20f5588c5142a40bed4a404457c261f20f62c07c

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -30 lines)			Patch
M	scripts/slave/recipes/ios/try.py	View	10 chunks	+0 lines, -10 lines	0 comments	Download
M	scripts/slave/recipes/ios/try.expected/basic.json	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/ios/try.expected/gn.json	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/ios/try.expected/gyp_goma.json	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/ios/try.expected/icu_patch.json	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/ios/try.expected/no_tests.json	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/ios/try.expected/parent.json	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/ios/try.expected/swarming.json	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/ios/try.expected/swarming_tests_skipped.json	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/ios/try.expected/without_patch_failure.json	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/ios/try.expected/without_patch_success.json	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Depends on Patchset:

Dependent Patchsets:

Total messages: 7 (3 generated)

smut

lgtm, you could do this downstream too if you want. I think it has the ...

4 years, 3 months ago (2016-09-06 21:47:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313723008/1

4 years, 3 months ago (2016-09-06 21:48:04 UTC) #5

commit-bot: I haz the power

4 years, 3 months ago (2016-09-06 21:52:44 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/20f5588c5142a40bed4a...