Make chromium_android recipe_module expectations more accurate.

Make chromium_android recipe_module expectations more accurate.

patch_url was used to fetch patch files from an SVN server and is no longer
applicable.

R=martiniss@chromium.org
BUG=643885
Committed: https://chromium.googlesource.com/chromium/tools/build/+/5350aae99f6fa91464136f36613c94a2527b0878

[martiniss, 2016-09-06 21:28:18]

https://codereview.chromium.org/2315823002/diff/1/scripts/slave/recipe_module...
File
scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_allow_high_battery_temp_basic.json
(right):

https://codereview.chromium.org/2315823002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_allow_high_battery_temp_basic.json:853:
"{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"],
\"buildername\": \"perf_runner_allow_high_battery_temp\", \"buildnumber\": 571,
\"internal\": true, \"issue\": \"123456789\", \"mastername\":
\"chromium.testing.master\", \"patchset\": \"1\", \"recipe\":
\"chromium_android:example\", \"repo_name\": \"src/repo\", \"repo_url\":
\"svn://svn.chromium.org/chrome/trunk/src\", \"revision\":
\"4f4b02f6b7fa20a3a25682c457bbc8ad589c8a00\", \"rietveld\":
\"http://rietveld.example.com\", \"slavename\": \"tehslave\", \"workdir\":
\"/path/to/workdir/TestSlavename\"}",
This still has svn in it. Shouldn't this not be here?

[iannucci, 2016-09-06 21:48:21]

The expectations still have repo_url. I'm just trying to get rid of
patch_url. Feel free to change others as needed :D

If you want me to change that too let me know what to change it to and I
shall do so

On Tue, Sep 6, 2016, 14:28 <martiniss@chromium.org> wrote:

>
>
>
https://codereview.chromium.org/2315823002/diff/1/scripts/slave/recipe_module...
> File
>
>
scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_allow_high_battery_temp_basic.json
> (right):
>
>
>
https://codereview.chromium.org/2315823002/diff/1/scripts/slave/recipe_module...
>
>
scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_allow_high_battery_temp_basic.json:853:
>
> "{\"blamelist\": [\"cool_dev1337@chromium.org\&quot;,
> \"hax@chromium.org\"],
> \"buildername\": \"perf_runner_allow_high_battery_temp\",
> \"buildnumber\": 571, \"internal\": true, \"issue\": \"123456789\",
> \"mastername\": \"chromium.testing.master\", \"patchset\": \"1\",
> \"recipe\": \"chromium_android:example\", \"repo_name\": \"src/repo\",
> \"repo_url\": \"svn://svn.chromium.org/chrome/trunk/src\
> <http://svn.chromium.org/chrome/trunk/src%5C>", \"revision\":
> \"4f4b02f6b7fa20a3a25682c457bbc8ad589c8a00\", \"rietveld\":
> \"http://rietveld.example.com\", \"slavename\": \"tehslave\",
> \"workdir\": \"/path/to/workdir/TestSlavename\"}",
> This still has svn in it. Shouldn't this not be here?
>
> https://codereview.chromium.org/2315823002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[martiniss, 2016-09-06 22:26:25]

lgtm

[iannucci, 2016-09-06 22:26:30]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2016-09-06 22:26:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 22:30:40]

Description was changed from

==========
Make chromium_android recipe_module expectations more accurate.

patch_url was used to fetch patch files from an SVN server and is no longer
applicable.

R=martiniss@chromium.org
BUG=643885
==========

to

==========
Make chromium_android recipe_module expectations more accurate.

patch_url was used to fetch patch files from an SVN server and is no longer
applicable.

R=martiniss@chromium.org
BUG=643885

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/5350aae99f6fa9146413...
==========

[commit-bot: I haz the power, 2016-09-06 22:30:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/5350aae99f6fa9146413...