Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2315813002: Make libyuv expectations more realistic. (Closed)

Created:
4 years, 3 months ago by iannucci
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Make libyuv expectations more realistic. Removes --patch_url (which fetches a patch from an svn server) and replaces with properties that this recipe actually takes in production (e.g. for rietveld patches). R=kjellander@chromium.org BUG=643885 Committed: https://chromium.googlesource.com/chromium/tools/build/+/6821d6b5eb52ee5a1342493984dcef70c5bdeddf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -115 lines) Patch
M scripts/slave/recipes/libyuv/libyuv.py View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android.json View 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_arm64.json View 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_clang.json View 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_gn.json View 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_gn_rel.json View 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_mips.json View 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_rel.json View 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_x64.json View 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_x86.json View 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios.json View 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios_arm64.json View 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios_arm64_rel.json View 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios_rel.json View 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux.json View 2 chunks +8 lines, -4 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_asan.json View 2 chunks +8 lines, -4 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_forced.json View 2 chunks +8 lines, -4 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_gcc.json View 2 chunks +8 lines, -4 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_gn.json View 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_gn_rel.json View 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_memcheck.json View 2 chunks +8 lines, -4 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_msan.json View 2 chunks +8 lines, -4 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_rel.json View 2 chunks +8 lines, -4 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_tsan2.json View 2 chunks +8 lines, -4 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_ubsan.json View 2 chunks +8 lines, -4 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_ubsan_vptr.json View 2 chunks +8 lines, -4 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac.json View 2 chunks +8 lines, -4 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac_asan.json View 2 chunks +8 lines, -4 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac_gn.json View 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac_gn_rel.json View 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac_rel.json View 2 chunks +8 lines, -4 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win.json View 2 chunks +8 lines, -4 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_clang.json View 2 chunks +8 lines, -4 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_clang_rel.json View 2 chunks +8 lines, -4 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_rel.json View 2 chunks +8 lines, -4 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_clang_rel.json View 2 chunks +8 lines, -4 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_gn.json View 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_gn_rel.json View 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_rel.json View 2 chunks +8 lines, -4 lines 0 comments Download

Dependent Patchsets:

Issue 2313723008 Patch 1

Messages

Total messages: 6 (2 generated)
iannucci
PTAL
4 years, 3 months ago (2016-09-06 19:31:55 UTC) #1
kjellander_chromium
Thanks. I noticed this yesterday too since I've been giving libyuv some love (finally). lgtm.
4 years, 3 months ago (2016-09-06 20:01:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315813002/1
4 years, 3 months ago (2016-09-06 20:40:45 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 20:45:43 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/6821d6b5eb52ee5a1342...

Powered by Google App Engine
This is Rietveld 408576698