[builtins] Migrate Number predicates and make them optimizable.

[builtins] Migrate Number predicates and make them optimizable.

Migrate the isNaN, isFinite, Number.isFinite, Number.isInteger,
Number.isSafeInteger and Number.isNaN predicates to TurboFan
builtins and make them optimizable (for certain input types) in
JavaScript callees being optimized by TurboFan. That means both
the baseline and the optimized version is now always at maximum,
consistent performance. Especially TurboFan suffered from poor
baseline (and optimized) performance because it cannot play the
same weird tricks that Crankshaft plays for %_IsSmi.

This also adds a bunch of new tests to properly cover the use
of the Harmony predicates in optimized code.

R=franzih@chromium.org
BUG=v8:5049, v8:5267
Committed: https://crrev.com/7ac19fe59823c82a8cf484d50a26767e1c828572
Cr-Commit-Position: refs/heads/master@{#39242}

[Benedikt Meurer, 2016-09-06 20:42:06]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 20:42:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-09-06 20:45:09]

Hey Franziska,

Here's some refactoring for 6 number predicates, 2 on the global object and 4
harmony ones on the Number constructor. Adds both fast baseline version as
TurboFan builtin as well as some inline support for TurboFan JavaScript
compilation.
Please take a look.

Thanks,
Benedikt

[commit-bot: I haz the power, 2016-09-06 21:42:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 21:42:49]

Dry run: This issue passed the CQ dry run.

[Franzi, 2016-09-07 08:40:06]

lgtm

[Benedikt Meurer (Google), 2016-09-07 10:11:51]

The CQ bit was checked by bmeurer@google.com

[commit-bot: I haz the power, 2016-09-07 10:11:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 10:14:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-07 10:14:52]

Description was changed from

==========
[builtins] Migrate Number predicates and make them optimizable.

Migrate the isNaN, isFinite, Number.isFinite, Number.isInteger,
Number.isSafeInteger and Number.isNaN predicates to TurboFan
builtins and make them optimizable (for certain input types) in
JavaScript callees being optimized by TurboFan. That means both
the baseline and the optimized version is now always at maximum,
consistent performance. Especially TurboFan suffered from poor
baseline (and optimized) performance because it cannot play the
same weird tricks that Crankshaft plays for %_IsSmi.

This also adds a bunch of new tests to properly cover the use
of the Harmony predicates in optimized code.

R=franzih@chromium.org
BUG=v8:5049,v8:5267
==========

to

==========
[builtins] Migrate Number predicates and make them optimizable.

Migrate the isNaN, isFinite, Number.isFinite, Number.isInteger,
Number.isSafeInteger and Number.isNaN predicates to TurboFan
builtins and make them optimizable (for certain input types) in
JavaScript callees being optimized by TurboFan. That means both
the baseline and the optimized version is now always at maximum,
consistent performance. Especially TurboFan suffered from poor
baseline (and optimized) performance because it cannot play the
same weird tricks that Crankshaft plays for %_IsSmi.

This also adds a bunch of new tests to properly cover the use
of the Harmony predicates in optimized code.

R=franzih@chromium.org
BUG=v8:5049,v8:5267

Committed: https://crrev.com/7ac19fe59823c82a8cf484d50a26767e1c828572
Cr-Commit-Position: refs/heads/master@{#39242}
==========

[commit-bot: I haz the power, 2016-09-07 10:14:53]

Patchset 1 (id:??) landed as
https://crrev.com/7ac19fe59823c82a8cf484d50a26767e1c828572
Cr-Commit-Position: refs/heads/master@{#39242}