Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Side by Side Diff: src/builtins/builtins-global.cc

Issue 2313073002: [builtins] Migrate Number predicates and make them optimizable. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins/builtins.h ('k') | src/builtins/builtins-number.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/builtins/builtins.h" 5 #include "src/builtins/builtins.h"
6 #include "src/builtins/builtins-utils.h" 6 #include "src/builtins/builtins-utils.h"
7 7
8 #include "src/code-factory.h"
8 #include "src/compiler.h" 9 #include "src/compiler.h"
9 #include "src/uri.h" 10 #include "src/uri.h"
10 11
11 namespace v8 { 12 namespace v8 {
12 namespace internal { 13 namespace internal {
13 14
14 // ES6 section 18.2.6.2 decodeURI (encodedURI) 15 // ES6 section 18.2.6.2 decodeURI (encodedURI)
15 BUILTIN(GlobalDecodeURI) { 16 BUILTIN(GlobalDecodeURI) {
16 HandleScope scope(isolate); 17 HandleScope scope(isolate);
17 Handle<String> encoded_uri; 18 Handle<String> encoded_uri;
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 Handle<JSFunction> function; 93 Handle<JSFunction> function;
93 ASSIGN_RETURN_FAILURE_ON_EXCEPTION( 94 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
94 isolate, function, Compiler::GetFunctionFromString( 95 isolate, function, Compiler::GetFunctionFromString(
95 handle(target->native_context(), isolate), 96 handle(target->native_context(), isolate),
96 Handle<String>::cast(x), NO_PARSE_RESTRICTION)); 97 Handle<String>::cast(x), NO_PARSE_RESTRICTION));
97 RETURN_RESULT_OR_FAILURE( 98 RETURN_RESULT_OR_FAILURE(
98 isolate, 99 isolate,
99 Execution::Call(isolate, function, target_global_proxy, 0, nullptr)); 100 Execution::Call(isolate, function, target_global_proxy, 0, nullptr));
100 } 101 }
101 102
103 // ES6 section 18.2.2 isFinite ( number )
104 void Builtins::Generate_GlobalIsFinite(CodeStubAssembler* assembler) {
105 typedef CodeStubAssembler::Label Label;
106 typedef compiler::Node Node;
107 typedef CodeStubAssembler::Variable Variable;
108
109 Node* context = assembler->Parameter(4);
110
111 Label return_true(assembler), return_false(assembler);
112
113 // We might need to loop once for ToNumber conversion.
114 Variable var_num(assembler, MachineRepresentation::kTagged);
115 Label loop(assembler, &var_num);
116 var_num.Bind(assembler->Parameter(1));
117 assembler->Goto(&loop);
118 assembler->Bind(&loop);
119 {
120 // Load the current {num} value.
121 Node* num = var_num.value();
122
123 // Check if {num} is a Smi or a HeapObject.
124 assembler->GotoIf(assembler->WordIsSmi(num), &return_true);
125
126 // Check if {num} is a HeapNumber.
127 Label if_numisheapnumber(assembler),
128 if_numisnotheapnumber(assembler, Label::kDeferred);
129 assembler->Branch(assembler->WordEqual(assembler->LoadMap(num),
130 assembler->HeapNumberMapConstant()),
131 &if_numisheapnumber, &if_numisnotheapnumber);
132
133 assembler->Bind(&if_numisheapnumber);
134 {
135 // Check if {num} contains a finite, non-NaN value.
136 Node* num_value = assembler->LoadHeapNumberValue(num);
137 assembler->BranchIfFloat64IsNaN(
138 assembler->Float64Sub(num_value, num_value), &return_false,
139 &return_true);
140 }
141
142 assembler->Bind(&if_numisnotheapnumber);
143 {
144 // Need to convert {num} to a Number first.
145 Callable callable = CodeFactory::NonNumberToNumber(assembler->isolate());
146 var_num.Bind(assembler->CallStub(callable, context, num));
147 assembler->Goto(&loop);
148 }
149 }
150
151 assembler->Bind(&return_true);
152 assembler->Return(assembler->BooleanConstant(true));
153
154 assembler->Bind(&return_false);
155 assembler->Return(assembler->BooleanConstant(false));
156 }
157
158 // ES6 section 18.2.3 isNaN ( number )
159 void Builtins::Generate_GlobalIsNaN(CodeStubAssembler* assembler) {
160 typedef CodeStubAssembler::Label Label;
161 typedef compiler::Node Node;
162 typedef CodeStubAssembler::Variable Variable;
163
164 Node* context = assembler->Parameter(4);
165
166 Label return_true(assembler), return_false(assembler);
167
168 // We might need to loop once for ToNumber conversion.
169 Variable var_num(assembler, MachineRepresentation::kTagged);
170 Label loop(assembler, &var_num);
171 var_num.Bind(assembler->Parameter(1));
172 assembler->Goto(&loop);
173 assembler->Bind(&loop);
174 {
175 // Load the current {num} value.
176 Node* num = var_num.value();
177
178 // Check if {num} is a Smi or a HeapObject.
179 assembler->GotoIf(assembler->WordIsSmi(num), &return_false);
180
181 // Check if {num} is a HeapNumber.
182 Label if_numisheapnumber(assembler),
183 if_numisnotheapnumber(assembler, Label::kDeferred);
184 assembler->Branch(assembler->WordEqual(assembler->LoadMap(num),
185 assembler->HeapNumberMapConstant()),
186 &if_numisheapnumber, &if_numisnotheapnumber);
187
188 assembler->Bind(&if_numisheapnumber);
189 {
190 // Check if {num} contains a NaN.
191 Node* num_value = assembler->LoadHeapNumberValue(num);
192 assembler->BranchIfFloat64IsNaN(num_value, &return_true, &return_false);
193 }
194
195 assembler->Bind(&if_numisnotheapnumber);
196 {
197 // Need to convert {num} to a Number first.
198 Callable callable = CodeFactory::NonNumberToNumber(assembler->isolate());
199 var_num.Bind(assembler->CallStub(callable, context, num));
200 assembler->Goto(&loop);
201 }
202 }
203
204 assembler->Bind(&return_true);
205 assembler->Return(assembler->BooleanConstant(true));
206
207 assembler->Bind(&return_false);
208 assembler->Return(assembler->BooleanConstant(false));
209 }
210
102 } // namespace internal 211 } // namespace internal
103 } // namespace v8 212 } // namespace v8
OLDNEW
« no previous file with comments | « src/builtins/builtins.h ('k') | src/builtins/builtins-number.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698