Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: test/cctest/test-serialize.cc

Issue 2313073002: [builtins] Migrate Number predicates and make them optimizable. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.h ('k') | test/mjsunit/compiler/number-isfinite.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-serialize.cc
diff --git a/test/cctest/test-serialize.cc b/test/cctest/test-serialize.cc
index 4373ddca9655771e6b390a9880564c79dcd48a75..e1b0be2adf800b6eae5ec01d894f75dc3adcf585 100644
--- a/test/cctest/test-serialize.cc
+++ b/test/cctest/test-serialize.cc
@@ -810,7 +810,7 @@ TEST(SnapshotDataBlobWithWarmup) {
// Running the warmup script has effect on whether functions are
// pre-compiled, but does not pollute the context.
CHECK(IsCompiled("Math.abs"));
- CHECK(!IsCompiled("Number.isFinite"));
+ CHECK(!IsCompiled("Number.parseInt"));
CHECK(CompileRun("Math.random")->IsFunction());
}
isolate->Dispose();
@@ -820,8 +820,8 @@ TEST(CustomSnapshotDataBlobWithWarmup) {
DisableTurbofan();
const char* source =
"function f() { return Math.abs(1); }\n"
- "function g() { return Number.isFinite(1); }\n"
- "Number.isNaN(1);"
+ "function g() { return Number.parseInt(1); }\n"
+ "Number.parseFloat(1);"
"var a = 5";
const char* warmup = "a = f()";
@@ -845,8 +845,8 @@ TEST(CustomSnapshotDataBlobWithWarmup) {
CHECK(IsCompiled("f"));
CHECK(IsCompiled("Math.abs"));
CHECK(!IsCompiled("g"));
- CHECK(!IsCompiled("Number.isFinite"));
- CHECK(!IsCompiled("Number.isNaN"));
+ CHECK(!IsCompiled("Number.parseInt"));
+ CHECK(!IsCompiled("Number.parseFloat"));
CHECK_EQ(5, CompileRun("a")->Int32Value(context).FromJust());
}
isolate->Dispose();
« no previous file with comments | « src/objects.h ('k') | test/mjsunit/compiler/number-isfinite.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698