Add flag to control whether cronet is build on iOS.

Add flag to control whether cronet is build on iOS.

Compiling cronet requires particular flags and it is advised to use the
helper script components/cronet/tools/cr_cronet.py to prepare the build
so add a gn flag to control whether cronet is build on iOS.

Due to the specific flags, the compilation of cronet is sometimes broken
on the downstream iOS bots causing unnecessary churn as cronet is unused
by Chrome on iOS.

BUG=640686
Committed: https://crrev.com/3f45c2d2dbe863857e3a3c24212ec0d995ed445f
Cr-Commit-Position: refs/heads/master@{#417301}

[sdefresne, 2016-09-06 15:44:08]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 15:44:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-09-06 15:44:41]

sdefresne@chromium.org changed reviewers:
+ mef@chromium.org

[sdefresne, 2016-09-06 15:44:42]

Please take a look and send to CQ if LGTY.

[sdefresne, 2016-09-06 15:54:36]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[mef, 2016-09-06 15:54:40]

On 2016/09/06 15:44:42, sdefresne wrote:
> Please take a look and send to CQ if LGTY.

This looks good, but I have a complemetary question - the iOS trybot is trying
to build Chrome, and fails:
https://uberchromegw.corp.google.com/i/tryserver.chromium.mac/builders/ios-si...

Can this approach address that issue?

[commit-bot: I haz the power, 2016-09-06 15:54:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-09-06 16:07:13]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 16:07:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-09-06 16:08:12]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 16:08:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-09-06 16:08:21]

Patchset #3 (id:40001) has been deleted

[sdefresne, 2016-09-06 16:09:16]

On 2016/09/06 15:54:40, mef wrote:
> On 2016/09/06 15:44:42, sdefresne wrote:
> > Please take a look and send to CQ if LGTY.
> 
> This looks good, but I have a complemetary question - the iOS trybot is trying
> to build Chrome, and fails:
>
https://uberchromegw.corp.google.com/i/tryserver.chromium.mac/builders/ios-si...
> 
> Can this approach address that issue?

I guess so. I've changed CL to only compile //ios/chrome if not building cronet
(see patchset #3).
WDYT?

[mef, 2016-09-06 16:28:45]

On 2016/09/06 16:09:16, sdefresne wrote:
> On 2016/09/06 15:54:40, mef wrote:
> > On 2016/09/06 15:44:42, sdefresne wrote:
> > > Please take a look and send to CQ if LGTY.
> > 
> > This looks good, but I have a complemetary question - the iOS trybot is
trying
> > to build Chrome, and fails:
> >
>
https://uberchromegw.corp.google.com/i/tryserver.chromium.mac/builders/ios-si...
> > 
> > Can this approach address that issue?
> 
> I guess so. I've changed CL to only compile //ios/chrome if not building
cronet
> (see patchset #3).
> WDYT?

I think it is reasonable change, but could you try it on ios-simulator-cronet
trybot?

[sdefresne, 2016-09-06 16:31:23]

The CQ bit was unchecked by sdefresne@chromium.org

[sdefresne, 2016-09-06 16:32:01]

On 2016/09/06 16:28:45, mef wrote:
> On 2016/09/06 16:09:16, sdefresne wrote:
> > On 2016/09/06 15:54:40, mef wrote:
> > > On 2016/09/06 15:44:42, sdefresne wrote:
> > > > Please take a look and send to CQ if LGTY.
> > > 
> > > This looks good, but I have a complemetary question - the iOS trybot is
> trying
> > > to build Chrome, and fails:
> > >
> >
>
https://uberchromegw.corp.google.com/i/tryserver.chromium.mac/builders/ios-si...
> > > 
> > > Can this approach address that issue?
> > 
> > I guess so. I've changed CL to only compile //ios/chrome if not building
> cronet
> > (see patchset #3).
> > WDYT?
> 
> I think it is reasonable change, but could you try it on ios-simulator-cronet
> trybot?

Sure, here it is :
https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-cr...

[sdefresne, 2016-09-06 16:59:14]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2016-09-06 16:59:28]

The CQ bit was unchecked by sdefresne@chromium.org

[sdefresne, 2016-09-06 17:15:05]

On 2016/09/06 16:32:01, sdefresne wrote:
> On 2016/09/06 16:28:45, mef wrote:
> > On 2016/09/06 16:09:16, sdefresne wrote:
> > > On 2016/09/06 15:54:40, mef wrote:
> > > > On 2016/09/06 15:44:42, sdefresne wrote:
> > > > > Please take a look and send to CQ if LGTY.
> > > > 
> > > > This looks good, but I have a complemetary question - the iOS trybot is
> > trying
> > > > to build Chrome, and fails:
> > > >
> > >
> >
>
https://uberchromegw.corp.google.com/i/tryserver.chromium.mac/builders/ios-si...
> > > > 
> > > > Can this approach address that issue?
> > > 
> > > I guess so. I've changed CL to only compile //ios/chrome if not building
> > cronet
> > > (see patchset #3).
> > > WDYT?
> > 
> > I think it is reasonable change, but could you try it on
ios-simulator-cronet
> > trybot?
> 
> Sure, here it is :
>
https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-cr...

Hum, needed to make changes to //net due to dependency, will split this to
another CL, but first let's try to see if this please the bot.

[sdefresne, 2016-09-06 17:15:42]

Description was changed from

==========
Add flag to control whether cronet is build on iOS.

Compiling cronet requires particular flags and it is advised to use the
helper script components/cronet/tools/cr_cronet.py to prepare the build
so add a gn flag to control whether cronet is build on iOS.

Due to the specific flags, the compilation of cronet is sometimes broken
on the downstream iOS bots causin unnecessary churn as cronet is unused
by Chrome on iOS.

BUG=640686
==========

to

==========
Add flag to control whether cronet is build on iOS.

Compiling cronet requires particular flags and it is advised to use the
helper script components/cronet/tools/cr_cronet.py to prepare the build
so add a gn flag to control whether cronet is build on iOS.

Due to the specific flags, the compilation of cronet is sometimes broken
on the downstream iOS bots causing unnecessary churn as cronet is unused
by Chrome on iOS.

BUG=640686
==========

[sdefresne, 2016-09-07 09:05:32]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 09:05:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-09-07 09:06:56]

sdefresne@chromium.org changed reviewers:
+ asargent@chromium.org

[sdefresne, 2016-09-07 09:07:00]

The CQ bit was unchecked by sdefresne@chromium.org

[sdefresne, 2016-09-07 09:08:40]

mef: please take another look, I've sent it to ios-simulator-cronet after bot
after checking locally that the build succeed.

asargent: please take a look as OWNERS of components/update_client, the fix is
there to allow compilation when disable_file_support=true (which is set when
building cronet) using the macro exported by //net:net_config.

[mef, 2016-09-07 17:21:26]

lgtm

[asargent_no_longer_on_chrome, 2016-09-07 18:26:33]

Instead of commenting out essentially all the code in the file if
DISABLE_FILE_SUPPORT is defined, it seems like it would be better if we just
used a condition in the components/update_client/BUILD.gn file to skip compiling
the file altogether.

[sdefresne, 2016-09-08 07:58:18]

On 2016/09/07 18:26:33, Antony Sargent wrote:
> Instead of commenting out essentially all the code in the file if
> DISABLE_FILE_SUPPORT is defined, it seems like it would be better if we just
> used a condition in the components/update_client/BUILD.gn file to skip
compiling
> the file altogether.

Ack. This required extracting the disable_file_support variable to a new gni
file, so I've done this as a followup CL:
https://codereview.chromium.org/2318343003/.

[sdefresne, 2016-09-08 08:00:58]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2016-09-08 08:01:17]

sdefresne@chromium.org changed reviewers:
+ mef@google.com
- asargent@chromium.org, mef@chromium.org

[commit-bot: I haz the power, 2016-09-08 08:01:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-09-08 08:01:58]

On 2016/09/08 07:58:18, sdefresne wrote:
> On 2016/09/07 18:26:33, Antony Sargent wrote:
> > Instead of commenting out essentially all the code in the file if
> > DISABLE_FILE_SUPPORT is defined, it seems like it would be better if we just
> > used a condition in the components/update_client/BUILD.gn file to skip
> compiling
> > the file altogether.
> 
> Ack. This required extracting the disable_file_support variable to a new gni
> file, so I've done this as a followup CL:
> https://codereview.chromium.org/2318343003/.

asargent: as I've extracted the components/update_client code to a separate CL,
I no longer need you to review this CL, thank you.

[sdefresne, 2016-09-08 08:02:22]

The CQ bit was unchecked by sdefresne@chromium.org

[mef, 2016-09-08 13:22:04]

lgtm

[sdefresne, 2016-09-08 14:37:00]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-09-08 14:37:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 15:38:57]

Description was changed from

==========
Add flag to control whether cronet is build on iOS.

Compiling cronet requires particular flags and it is advised to use the
helper script components/cronet/tools/cr_cronet.py to prepare the build
so add a gn flag to control whether cronet is build on iOS.

Due to the specific flags, the compilation of cronet is sometimes broken
on the downstream iOS bots causing unnecessary churn as cronet is unused
by Chrome on iOS.

BUG=640686
==========

to

==========
Add flag to control whether cronet is build on iOS.

Compiling cronet requires particular flags and it is advised to use the
helper script components/cronet/tools/cr_cronet.py to prepare the build
so add a gn flag to control whether cronet is build on iOS.

Due to the specific flags, the compilation of cronet is sometimes broken
on the downstream iOS bots causing unnecessary churn as cronet is unused
by Chrome on iOS.

BUG=640686
==========

[commit-bot: I haz the power, 2016-09-08 15:39:01]

Committed patchset #7 (id:140001)

[commit-bot: I haz the power, 2016-09-08 15:40:41]

Description was changed from

==========
Add flag to control whether cronet is build on iOS.

Compiling cronet requires particular flags and it is advised to use the
helper script components/cronet/tools/cr_cronet.py to prepare the build
so add a gn flag to control whether cronet is build on iOS.

Due to the specific flags, the compilation of cronet is sometimes broken
on the downstream iOS bots causing unnecessary churn as cronet is unused
by Chrome on iOS.

BUG=640686
==========

to

==========
Add flag to control whether cronet is build on iOS.

Compiling cronet requires particular flags and it is advised to use the
helper script components/cronet/tools/cr_cronet.py to prepare the build
so add a gn flag to control whether cronet is build on iOS.

Due to the specific flags, the compilation of cronet is sometimes broken
on the downstream iOS bots causing unnecessary churn as cronet is unused
by Chrome on iOS.

BUG=640686

Committed: https://crrev.com/3f45c2d2dbe863857e3a3c24212ec0d995ed445f
Cr-Commit-Position: refs/heads/master@{#417301}
==========

[commit-bot: I haz the power, 2016-09-08 15:40:43]

Patchset 7 (id:??) landed as
https://crrev.com/3f45c2d2dbe863857e3a3c24212ec0d995ed445f
Cr-Commit-Position: refs/heads/master@{#417301}