Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 2318343003: Fix compilation of components_unittests with disable_file_support=true. (Closed)

Created:
4 years, 3 months ago by sdefresne
Modified:
4 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix compilation of components_unittests with disable_file_support=true. The test components/update_client/crx_downloader_unittest.cc depends on net::LocalHostTestURLRequestInterceptor class that is not compiled when disable_file_support is set to true. Add a new file src/net/features.gni to allow conditional compilation based on that flag from outside of //net. BUG=640686 Committed: https://crrev.com/eb265869a6f4cbf1472b3762f83779cb01b6c07e Cr-Commit-Position: refs/heads/master@{#417287}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -19 lines) Patch
M components/update_client/BUILD.gn View 3 chunks +6 lines, -1 line 0 comments Download
M net/BUILD.gn View 2 chunks +1 line, -18 lines 0 comments Download
A net/features.gni View 1 chunk +23 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
sdefresne
This fix is required for fixing ios-simulator-cronet bot that build with disable_file_support set to true ...
4 years, 3 months ago (2016-09-08 07:57:38 UTC) #4
mef
On 2016/09/08 07:57:38, sdefresne wrote: > This fix is required for fixing ios-simulator-cronet bot that ...
4 years, 3 months ago (2016-09-08 13:25:50 UTC) #7
asargent_no_longer_on_chrome
lgtm
4 years, 3 months ago (2016-09-08 13:39:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318343003/1
4 years, 3 months ago (2016-09-08 13:55:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 14:27:31 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 14:29:37 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb265869a6f4cbf1472b3762f83779cb01b6c07e
Cr-Commit-Position: refs/heads/master@{#417287}

Powered by Google App Engine
This is Rietveld 408576698