components/cronet/tools/cr_cronet.py - Issue 2312963002: Add flag to control whether cronet is build on iOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/tools/cr_cronet.py

Issue 2312963002: Add flag to control whether cronet is build on iOS. (Closed)

Patch Set: Rebase on top of CL fixing compilation with disable_file_support. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/cronet/tools/cr_cronet.py

diff --git a/components/cronet/tools/cr_cronet.py b/components/cronet/tools/cr_cronet.py

index 69db170dfcc2387b5d97806fb113d197ab41c772..579fc71893a91ef8b55267480d74c9ec650c833b 100755

--- a/components/cronet/tools/cr_cronet.py

+++ b/components/cronet/tools/cr_cronet.py

@@ -79,12 +79,14 @@ def main():

if is_os:

target_os = 'ios'

test_target = 'cronet_test'

- gn_args = 'target_cpu = "x64" '

+ gn_args = 'is_cronet_build=true is_component_build=false '

gn_extra = '--ide=xcode'

- out_dir_suffix = '-iphonesimulator'

if options.iphoneos:

- gn_args = 'target_cpu = "arm64" '

+ gn_args += ' target_cpu="arm64" '

out_dir_suffix = '-iphoneos'

+ else:

+ gn_args += ' target_cpu="x64" '

+ out_dir_suffix = '-iphonesimulator'

else:

target_os = 'android'

test_target = 'cronet_test_instrumentation_apk'

« no previous file with comments | « no previous file | ios/BUILD.gn » ('j') | no next file with comments »