Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 231283003: Password manager: introduce logging for the internals page (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Uses StringID Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index ed721657823aa0ce0f0d422e91e29c365c4f0267..03cf0b8631e08f1aecc9ef9a2e50aa81b7eda048 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -25,6 +25,7 @@
#include "components/password_manager/core/browser/password_manager.h"
#include "components/password_manager/core/browser/password_manager_logger.h"
#include "components/password_manager/core/browser/password_manager_metrics_util.h"
+#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_contents_view.h"
#include "ipc/ipc_message_macros.h"
@@ -181,6 +182,11 @@ void ChromePasswordManagerClient::SetLogger(
// instances to 1 in normal profiles, and 0 in incognito.
DCHECK(!logger || !logger_);
logger_ = logger;
+
+ // We need to inform also the renderer side that we now want to start or stop
+ // logging.
Ilya Sherman 2014/04/23 05:19:56 nit: "Also inform the renderer process to start or
vabr (Chromium) 2014/04/23 18:15:35 Done.
+ web_contents()->GetRenderViewHost()->Send(new AutofillMsg_ChangeLoggingState(
+ web_contents()->GetRenderViewHost()->GetRoutingID(), logger != NULL));
}
void ChromePasswordManagerClient::LogSavePasswordProgress(

Powered by Google App Engine
This is Rietveld 408576698