Password manager: introduce logging for the internals page

chrome/browser/ui/login/login_prompt.cc

Index: chrome/browser/ui/login/login_prompt.cc
diff --git a/chrome/browser/ui/login/login_prompt.cc b/chrome/browser/ui/login/login_prompt.cc
index 37922269d3a081eda76bd60bd0ab5cb2e5dabab4..77d72ed943ec2900d636f7b7984a6530145d4198 100644
--- a/chrome/browser/ui/login/login_prompt.cc
+++ b/chrome/browser/ui/login/login_prompt.cc
@@ -14,6 +14,7 @@
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 #include "chrome/browser/prerender/prerender_contents.h"
 #include "chrome/browser/tab_contents/tab_util.h"
+#include "components/password_manager/core/browser/browser_save_password_progress_logger.h"
 #include "components/password_manager/core/browser/password_manager.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_registrar.h"
@@ -32,6 +33,7 @@
 #include "ui/gfx/text_elider.h"
 
 using autofill::PasswordForm;
+using autofill::SavePasswordProgressLogger;
 using content::BrowserThread;
 using content::NavigationController;
 using content::RenderViewHost;
@@ -135,7 +137,17 @@ void LoginHandler::SetAuth(const base::string16& username,
                            const base::string16& password) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 
-  if (TestAndSetAuthHandled())
+  bool already_handled = TestAndSetAuthHandled();
+  scoped_ptr<password_manager::BrowserSavePasswordProgressLogger> logger;
+  if (password_manager_ && password_manager_->client()->IsLoggingActive()) {
+    logger.reset(new password_manager::BrowserSavePasswordProgressLogger(
+        password_manager_->client()));
+    logger->LogMessage(SavePasswordProgressLogger::STRING_SET_AUTH_METHOD);

[Ilya Sherman, 2014/04/23 05:19:56]

nit: Please move the construction of the logger, as well as this first message,
to be above where |already_handled| is defined.  That helps make this logic
easier to follow.

[vabr (Chromium), 2014/04/23 18:15:35]

Done.

+    logger->LogBoolean(
+        SavePasswordProgressLogger::STRING_AUTHENTICATION_HANDLED,
+        already_handled);
+  }
+  if (already_handled )

[Ilya Sherman, 2014/04/23 05:19:56]

nit: Spurious space.

[vabr (Chromium), 2014/04/23 18:15:35]

Done.

     return;
 
   // Tell the password manager the credentials were submitted / accepted.
@@ -143,6 +155,9 @@ void LoginHandler::SetAuth(const base::string16& username,
     password_form_.username_value = username;
     password_form_.password_value = password;
     password_manager_->ProvisionallySavePassword(password_form_);
+    if (logger)

[Ilya Sherman, 2014/04/23 05:19:56]

nit: Needs curly braces.

[vabr (Chromium), 2014/04/23 18:15:35]

Done.

+      logger->LogPasswordForm(
+          SavePasswordProgressLogger::STRING_LOGINHANDLER_FORM, password_form_);
   }
 
   // Calling NotifyAuthSupplied() directly instead of posting a task