Password manager: introduce logging for the internals page

chrome/browser/password_manager/chrome_password_manager_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/memory/singleton.h"
 #include "base/metrics/histogram.h"
 #include "chrome/browser/password_manager/password_manager_util.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/password_manager/save_password_infobar_delegate.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #include "chrome/browser/ui/autofill/password_generation_popup_controller_impl.h"
 #include "chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/chrome_version_info.h"
 #include "components/autofill/content/common/autofill_messages.h"
 #include "components/autofill/core/browser/password_generator.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/password_manager/core/browser/password_form_manager.h"
 #include "components/password_manager/core/browser/password_manager.h"
 #include "components/password_manager/core/browser/password_manager_logger.h"
 #include "components/password_manager/core/browser/password_manager_metrics_util.h"
+#include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_view.h"
 #include "ipc/ipc_message_macros.h"
 
 #if defined(OS_ANDROID)
 #include "chrome/browser/android/password_authentication_manager.h"
 #endif  // OS_ANDROID
 
 namespace {
 
@@ skipping 136 matching lines @@
 
 void ChromePasswordManagerClient::SetLogger(
     password_manager::PasswordManagerLogger* logger) {
   // We should never be replacing one logger with a different one, because that
   // will leave the first without further updates, and the user likely confused.
   // TODO(vabr): For the reason above, before moving the internals page from
   // behind the flag, make sure to restrict the number of internals page
   // instances to 1 in normal profiles, and 0 in incognito.
   DCHECK(!logger || !logger_);
   logger_ = logger;
+
+  // We need to inform also the renderer side that we now want to start or stop
+  // logging.

[Ilya Sherman, 2014/04/23 05:19:56]

nit: "Also inform the renderer process to start or stop logging."

[vabr (Chromium), 2014/04/23 18:15:35]

Done.

+  web_contents()->GetRenderViewHost()->Send(new AutofillMsg_ChangeLoggingState(
+      web_contents()->GetRenderViewHost()->GetRoutingID(), logger != NULL));
 }
 
 void ChromePasswordManagerClient::LogSavePasswordProgress(
     const std::string& text) {
   if (IsLoggingActive())
     logger_->LogSavePasswordProgress(text);
 }
 
 bool ChromePasswordManagerClient::IsLoggingActive() const {
   return logger_ != NULL;
@@ skipping 90 matching lines @@
           web_contents(),
           web_contents()->GetView()->GetNativeView());
   popup_controller_->Show(false /* display_password */);
 #endif  // #if defined(USE_AURA)
 }
 
 void ChromePasswordManagerClient::CommitFillPasswordForm(
     autofill::PasswordFormFillData* data) {
   driver_.FillPasswordForm(*data);
 }