Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.h

Issue 2312823002: Added support for isInherited flags to ComputedStyleBase (Closed)
Patch Set: Rebase and a bit more cleanup work... Maybe needs a rethink Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h b/third_party/WebKit/Source/core/style/ComputedStyle.h
index a5535833ddf54ea9b5610ae4bbe33cf049fcc6c4..ae0c7e079ea26a3a8df417f981b5053224d49076 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h
@@ -331,7 +331,6 @@ protected:
// - The compareEqual() methods in the corresponding class
// InheritedFlags
unsigned m_isPointerEventsInherited : 1;
- unsigned m_isVisibilityInherited : 1;
// If you add more style bits here, you will also need to update ComputedStyle::copyNonInheritedFromCached()
// 68 bits
@@ -389,7 +388,6 @@ protected:
// All independently inherited properties default to being inherited.
m_nonInheritedData.m_isPointerEventsInherited = true;
- m_nonInheritedData.m_isVisibilityInherited = true;
}
private:
@@ -1261,10 +1259,6 @@ public:
void setVerticalAlign(EVerticalAlign v) { m_nonInheritedData.m_verticalAlign = v; }
void setVerticalAlignLength(const Length& length) { setVerticalAlign(VerticalAlignLength); SET_VAR(m_box, m_verticalAlign, length); }
- // visibility
- // TODO(sashab): Move this to ComputedStyleBase.
- void setVisibilityIsInherited(bool isInherited) { m_nonInheritedData.m_isVisibilityInherited = isInherited; }
-
// will-change
const Vector<CSSPropertyID>& willChangeProperties() const { return m_rareNonInheritedData->m_willChange->m_properties; }
bool willChangeContents() const { return m_rareNonInheritedData->m_willChange->m_contents; }

Powered by Google App Engine
This is Rietveld 408576698