Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Issue 2312353002: Revert of Add support for rich output inside of content editables. (Closed)

Created:
4 years, 3 months ago by David Tseng
Modified:
4 years, 3 months ago
Reviewers:
dmazzoni
CC:
aboxhall+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@editable_nav
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add support for rich output inside of content editables. (patchset #4 id:60001 of https://codereview.chromium.org/2263513004/ ) Reason for revert: Selection api's on node failing in many cases. Original issue's description: > Add support for rich output inside of content editables. > > This cl attempts to combine output from the editable* and output* modules. > > In particular, > - speech and braille hook into editable for line descriptions > - additions were made to make cursor selections reflect the current page selection > for braille > - a minor change to make braille ignore separator additions when there's > whitespace at the end of output. If not, cursor tracking breaks. > > What works: > - earcons, roles, states are now read as you move by line > - other behaviors (e.g. other unit selections, all text changes) are unaffected. > - DOM selection changes moves ChromeVox range (e.g. move by word via ctrl+right, ChromeVox range moves with it) > - ChromeVox range changes moves the DOM selection (e.g. move by heading, by word, line, etc moves the DOM selection there). > > BUG= > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/c249a9e6b2659b03d75a7cb548bbf02592ef5e34 > Cr-Commit-Position: refs/heads/master@{#414595} TBR=dmazzoni@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/31c56b7c038c7fdd9affc01ad112050af0f69aa6 Cr-Commit-Position: refs/heads/master@{#416742}

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
David Tseng
Created Revert of Add support for rich output inside of content editables.
4 years, 3 months ago (2016-09-06 20:24:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312353002/1
4 years, 3 months ago (2016-09-06 20:25:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 22:55:52 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 22:58:18 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31c56b7c038c7fdd9affc01ad112050af0f69aa6
Cr-Commit-Position: refs/heads/master@{#416742}

Powered by Google App Engine
This is Rietveld 408576698